From: Marek Vasut <marex@denx.de>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Bjorn Helgaas'" <bhelgaas@google.com>,
"'Fabio Estevam'" <festevam@gmail.com>,
linux-pci@vger.kernel.org,
"'Fabio Estevam'" <fabio.estevam@freescale.com>
Subject: Re: [PATCH 2/2] PCI: imx6: Remove unneeded 'goto err'
Date: Tue, 10 Dec 2013 19:48:39 +0100 [thread overview]
Message-ID: <201312101948.39891.marex@denx.de> (raw)
In-Reply-To: <000301cef56c$38fd71d0$aaf85570$%han@samsung.com>
On Tuesday, December 10, 2013 at 06:54:00 AM, Jingoo Han wrote:
> On Tuesday, December 10, 2013 7:38 AM, Bjorn Helgaas wrote:
> > On Mon, Dec 02, 2013 at 01:39:35AM -0200, Fabio Estevam wrote:
> > > From: Fabio Estevam <fabio.estevam@freescale.com>
> > >
> > > There is no need to use 'goto err' as we can directly return the
> > > errors.
> > >
> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Since there's no functional change, I also applied this one to
> > pci/host-imx6 for v3.14. I agree that leaving the DABT handler installed
> > is a bug and should be fixed by another patch.
>
> I also agree with Bjorn's opinion. :-)
> Fixing the DABT handler problem can be sent as another patch.
Hm, actually I suspect we cannot un-install the handler. See arch/arm/mm/fault.c
, the hook_fault_code() call is annotated __init , so it disappears after the
init sequence finishes. This basically leaves us with disallowing the mx6 pcie
driver to be removed from kernel (don't let it compile as a module), which I
dont think is much of a problem anyway.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-12-10 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 3:39 [PATCH 1/2] PCI: imx6: Remove unneeded check of platform_get_resource() Fabio Estevam
2013-12-02 3:39 ` [PATCH 2/2] PCI: imx6: Remove unneeded 'goto err' Fabio Estevam
2013-12-02 8:08 ` Marek Vasut
2013-12-04 18:31 ` Fabio Estevam
2013-12-04 23:49 ` Marek Vasut
2013-12-05 0:10 ` Fabio Estevam
2013-12-09 22:38 ` Bjorn Helgaas
2013-12-10 5:54 ` Jingoo Han
2013-12-10 18:48 ` Marek Vasut [this message]
2013-12-02 8:04 ` [PATCH 1/2] PCI: imx6: Remove unneeded check of platform_get_resource() Marek Vasut
2013-12-09 21:43 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312101948.39891.marex@denx.de \
--to=marex@denx.de \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.