From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============3482922359775313189=="
MIME-Version: 1.0
From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
Subject: Re: [Powertop] [PATCH v3 06/31] report-html: summary list and
 navigation
Date: Tue, 10 Dec 2013 22:53:41 +0300
Message-ID: <20131210195341.GA2422@swordfish>
In-Reply-To: 1384806442-20294-7-git-send-email-alexandra.yates@linux.intel.com
To: powertop@lists.01.org
List-ID: <powertop@lists.01.org>

--===============3482922359775313189==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On (11/18/13 12:26), Alexandra Yates wrote:
> Generates the html tags to add navigation and summary including css
> attribute support.
> =

> Signed-off-by: Alexandra Yates <alexandra.yates(a)linux.intel.com>
> ---
>  src/report/report-formatter-html.cpp |   18 ++++++++++++++++++
>  src/report/report-formatter-html.h   |    2 ++
>  2 files changed, 20 insertions(+)
> =

> diff --git a/src/report/report-formatter-html.cpp b/src/report/report-for=
matter-html.cpp
> index 2e59725..93a4c48 100644
> --- a/src/report/report-formatter-html.cpp
> +++ b/src/report/report-formatter-html.cpp
> @@ -516,3 +516,21 @@ report_formatter_html::add_title(struct tag_attr *ti=
tle_att, const char *title)
>  	addf_exact("<h2 class=3D\"%s\"> %s </h2>\n", title_att->css_class, titl=
e);
>  }
>  =

> +void
> +report_formatter_html::add_navigation()
> +{
> +	add_exact("<br/><nav id=3D\"main_menu\"> </nav>\n");
> +}
> +
> +void
> +report_formatter_html::add_summary_list(std::string *list, int size)
> +{
> +	int i;
> +	add_exact("<div><br/> <ul>\n");
> +	for (i=3D0; i < size; i+=3D2){


summary list is guaranteed to contain `2 * n' elements?

	-ss

> +		addf_exact("<li class=3D\"summary_list\"> <b> %s </b> %s </li>",
> +				list[i].c_str(), list[i+1].c_str());
> +	}
> +	add_exact("</ul> </div> <br />\n");
> +}
> +
> diff --git a/src/report/report-formatter-html.h b/src/report/report-forma=
tter-html.h
> index 0f508d3..261e0dd 100644
> --- a/src/report/report-formatter-html.h
> +++ b/src/report/report-formatter-html.h
> @@ -89,6 +89,8 @@ public:
>  	void add_div(struct tag_attr *div_attr);
>  	void end_div();
>  	void add_title(struct tag_attr *title_att, const char *title);
> +	void add_navigation();
> +	void add_summary_list(std::string *list, int size);
>  =

>  private:
>  	/* Document structure related functions */
> -- =

> 1.7.9.5
> =

> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>=20

--===============3482922359775313189==--