All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs_repair: fix process_bmbt_reclist_int
Date: Tue, 10 Dec 2013 13:06:52 -0800	[thread overview]
Message-ID: <20131210210652.GA5996@infradead.org> (raw)
In-Reply-To: <20131210205352.GC1935@sgi.com>

On Tue, Dec 10, 2013 at 02:53:52PM -0600, Ben Myers wrote:
> There is a set checks for corruption in block map btrees in
> process_bmbt_reclist_int that we identify but currently do not fix.  It
> appears that the author's intent in this function was to set error = 1,
> and then only clear it when all of the checks were completed
> successfully.  Unfortunately error can be cleared when it is used for
> the return value of blkmap_set_ext.  Some kinds of corruption are not
> being fixed, including duplicate extents, claiming free blocks, claiming
> metadata blocks, and multiply used blocks.
> 
> Fix this by using error2 for the return code from blkmap_set_ext.
> 
> Signed-off-by: Ben Myers <bpm@sgi.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-12-10 21:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 20:53 [PATCH v2] xfs_repair: fix process_bmbt_reclist_int Ben Myers
2013-12-10 21:06 ` Christoph Hellwig [this message]
2013-12-11 15:01 ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131210210652.GA5996@infradead.org \
    --to=hch@infradead.org \
    --cc=bpm@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.