From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Trippelsdorf Subject: Re: Can no longer shutdown after drm/radeon: Implement radeon_pci_shutdown Date: Wed, 11 Dec 2013 08:26:58 +0100 Message-ID: <20131211072658.GA273@x4> References: <84mwk86x5a.wl%peter.chubb@nicta.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.ud10.udmedia.de (ud10.udmedia.de [194.117.254.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AE04FAAB0 for ; Tue, 10 Dec 2013 23:33:40 -0800 (PST) Content-Disposition: inline In-Reply-To: <84mwk86x5a.wl%peter.chubb@nicta.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Peter Chubb Cc: alexander.deucher@amd.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 2013.12.11 at 11:37 +1100, Peter Chubb wrote: > On my HP Elitebook 8740w qith a Mobility Radeon HD 5870 > commit 846ae41ae99d314bf2a02784152208a6ddf7eddc > breaks shutdown. The machine hangs when trying to shutdown, kexec or > hibernate, before seeing the usual `machine halted' (or whatever) message. > > If I comment out thus: > > index 9f5ff28..40bff3c 100644 > --- a/drivers/gpu/drm/radeon/radeon_drv.c > +++ b/drivers/gpu/drm/radeon/radeon_drv.c > @@ -514,7 +514,7 @@ radeon_pci_shutdown(struct pci_dev *pdev) > { > struct drm_device *dev = pci_get_drvdata(pdev); > > - radeon_driver_unload_kms(dev); > + /*radeon_driver_unload_kms(dev);*/ > } > > then everything works again. Thsi is obviously not the proper fix. It would be interesting to know where exactly it hangs. Could you comment out the *_fini(rdev) calls in radeon_driver_unload_kms (drivers/gpu/drm/radeon/radeon_kms.c) one after the other to find out which one is responsible? -- Markus