All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: thomas.lendacky@amd.com
Cc: linux-crypto@vger.kernel.org
Subject: re: crypto: ccp - CCP SHA crypto API support
Date: Wed, 11 Dec 2013 13:51:50 +0300	[thread overview]
Message-ID: <20131211105150.GA422@elgon.mountain> (raw)

Hello Tom Lendacky,

The patch 0ab0a1d505ab: "crypto: ccp - CCP SHA crypto API support"
from Nov 12, 2013, leads to the following static checker warning:
	drivers/crypto/ccp/ccp-crypto-sha.c:182 ccp_do_sha_update()
	warn: should 'rctx->hash_cnt << 3' be a 64 bit type?

drivers/crypto/ccp/ccp-crypto-sha.c
   180                  sg_mark_end(sg);
   181  
   182          rctx->msg_bits += (rctx->hash_cnt << 3);        /* Total in bits */
                                   ^^^^^^^^^^^^^^^^^^^
This operation wraps if the msg is over 500MB.  I'm not sure if that's
possible, but ->msg_bits is declared as a u64 here and in
rctx->cmd.u.sha.msg_bits as well.

   183  
   184          memset(&rctx->cmd, 0, sizeof(rctx->cmd));


regards,
dan carpenter

             reply	other threads:[~2013-12-11 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11 10:51 Dan Carpenter [this message]
2013-12-11 14:45 ` crypto: ccp - CCP SHA crypto API support Tom Lendacky
2013-12-11 15:20   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211105150.GA422@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.