From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yh0-f45.google.com ([209.85.213.45]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqiMp-00010R-5H for linux-mtd@lists.infradead.org; Wed, 11 Dec 2013 11:54:16 +0000 Received: by mail-yh0-f45.google.com with SMTP id v1so4901579yhn.18 for ; Wed, 11 Dec 2013 03:53:52 -0800 (PST) Date: Wed, 11 Dec 2013 11:53:45 +0000 From: Lee Jones To: Marek Vasut Subject: Re: [PATCH V2 2/4] mtd: spi-nor: add the basic data structures Message-ID: <20131211115345.GL16780@lee--X1> References: <1386318764-15882-1-git-send-email-b32955@freescale.com> <201312101407.59958.marex@denx.de> <20131211062428.GA25147@shlinux2.ap.freescale.net> <201312111102.18554.marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201312111102.18554.marex@denx.de> Cc: angus.clark@st.com, broonie@linaro.org, linux-spi@vger.kernel.org, Huang Shijie , linux-mtd@lists.infradead.org, pekon@ti.com, sourav.poddar@ti.com, computersforpeace@gmail.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > > > > The spi_nor{} is cloned from the m25p{}. > > > > + struct spi_nor_xfer_cfg cfg; > > > > + > > > > + /* for write_reg */ > > > > + u8 cmd_buf[SPI_NOR_MAX_CMD_SIZE]; > > > > + > > > > + /* the two fundamental primitives */ > > > > + int (*read_xfer)(struct spi_nor *nor, struct spi_nor_xfer_cfg *cfg, > > > > + u8 *buf, size_t len); > > > > + int (*write_xfer)(struct spi_nor *nor, struct spi_nor_xfer_cfg *cfg, > > > > + u8 *buf, size_t len); > > > > + > > > > + int (*read_reg)(struct spi_nor *nor, u8 opcode, u8 *buf, int len); > > > > + int (*write_reg)(struct spi_nor *nor, u8 opcode, u8 *buf, int len, > > > > + int write_enable); > > > > > > Does the vybrid really support accelerated SPI NOR register IO or does it > > > > The vybrid does not support the accelerated SPI NOR register IO. > > these hooks are for Lee's driver. > > Which one please? It's not in Mainline yet, but the patches are on the list. If you search for st_spi_fsm, you'll find them. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V2 2/4] mtd: spi-nor: add the basic data structures Date: Wed, 11 Dec 2013 11:53:45 +0000 Message-ID: <20131211115345.GL16780@lee--X1> References: <1386318764-15882-1-git-send-email-b32955@freescale.com> <201312101407.59958.marex@denx.de> <20131211062428.GA25147@shlinux2.ap.freescale.net> <201312111102.18554.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Huang Shijie , dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, angus.clark-qxv4g6HH51o@public.gmane.org, pekon-l0cyMroinI0@public.gmane.org, sourav.poddar-l0cyMroinI0@public.gmane.org, broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Marek Vasut Return-path: Content-Disposition: inline In-Reply-To: <201312111102.18554.marex-ynQEQJNshbs@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: > > > > The spi_nor{} is cloned from the m25p{}. > > > > + struct spi_nor_xfer_cfg cfg; > > > > + > > > > + /* for write_reg */ > > > > + u8 cmd_buf[SPI_NOR_MAX_CMD_SIZE]; > > > > + > > > > + /* the two fundamental primitives */ > > > > + int (*read_xfer)(struct spi_nor *nor, struct spi_nor_xfer_cfg= *cfg, > > > > + u8 *buf, size_t len); > > > > + int (*write_xfer)(struct spi_nor *nor, struct spi_nor_xfer_cf= g *cfg, > > > > + u8 *buf, size_t len); > > > > + > > > > + int (*read_reg)(struct spi_nor *nor, u8 opcode, u8 *buf, int = len); > > > > + int (*write_reg)(struct spi_nor *nor, u8 opcode, u8 *buf, int= len, > > > > + int write_enable); > > >=20 > > > Does the vybrid really support accelerated SPI NOR register IO or= does it > >=20 > > The vybrid does not support the accelerated SPI NOR register IO. > > these hooks are for Lee's driver. >=20 > Which one please? It's not in Mainline yet, but the patches are on the list. If you search for st_spi_fsm, you'll find them. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 11 Dec 2013 11:53:45 +0000 Subject: [PATCH V2 2/4] mtd: spi-nor: add the basic data structures In-Reply-To: <201312111102.18554.marex@denx.de> References: <1386318764-15882-1-git-send-email-b32955@freescale.com> <201312101407.59958.marex@denx.de> <20131211062428.GA25147@shlinux2.ap.freescale.net> <201312111102.18554.marex@denx.de> Message-ID: <20131211115345.GL16780@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > > > The spi_nor{} is cloned from the m25p{}. > > > > + struct spi_nor_xfer_cfg cfg; > > > > + > > > > + /* for write_reg */ > > > > + u8 cmd_buf[SPI_NOR_MAX_CMD_SIZE]; > > > > + > > > > + /* the two fundamental primitives */ > > > > + int (*read_xfer)(struct spi_nor *nor, struct spi_nor_xfer_cfg *cfg, > > > > + u8 *buf, size_t len); > > > > + int (*write_xfer)(struct spi_nor *nor, struct spi_nor_xfer_cfg *cfg, > > > > + u8 *buf, size_t len); > > > > + > > > > + int (*read_reg)(struct spi_nor *nor, u8 opcode, u8 *buf, int len); > > > > + int (*write_reg)(struct spi_nor *nor, u8 opcode, u8 *buf, int len, > > > > + int write_enable); > > > > > > Does the vybrid really support accelerated SPI NOR register IO or does it > > > > The vybrid does not support the accelerated SPI NOR register IO. > > these hooks are for Lee's driver. > > Which one please? It's not in Mainline yet, but the patches are on the list. If you search for st_spi_fsm, you'll find them. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog