From: Thierry Reding <thierry.reding@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 0/4] Fix backlight on Armadillo 800 EVA
Date: Wed, 11 Dec 2013 15:15:46 +0000 [thread overview]
Message-ID: <20131211151545.GB31617@ulmo.nvidia.com> (raw)
In-Reply-To: <1386730098-26641-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
On Wed, Dec 11, 2013 at 03:48:14AM +0100, Laurent Pinchart wrote:
> Hello,
>
> Commit 22ceeee16eb8f0d04de3ef43a5174fb30ec18af9 ("pwm-backlight: Add power
> supply support") added a mandatory power supply for the PWM backlight,
> resulting in broken backlight on the Armadillo board. This patch set fixes the
> issue by adding power supplies to board code and DT, and adds proper handling
> of the panel enable signal through the PWM backlight enable GPIO.
>
> Patch 1/4 fixes a v3.13 regression.
Actually there should be no regression at all here. The regulator core
handles this case by providing a dummy if the property hasn't been
specified in DT.
> Strictly speaking patch 3/4 is as well, but the backlight was broken
> anyway with DT due to the enable GPIO not being handled at all, so
> there's no need to push it to v3.13.
If the backlight was broken anyway with DT, how could this new patch
break it I wonder.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-11 15:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 2:48 [PATCH 0/4] Fix backlight on Armadillo 800 EVA Laurent Pinchart
2013-12-11 15:15 ` Thierry Reding [this message]
2013-12-11 15:35 ` Laurent Pinchart
2013-12-16 2:22 ` Simon Horman
2013-12-16 15:43 ` Laurent Pinchart
2013-12-17 0:20 ` Simon Horman
2013-12-17 0:56 ` Simon Horman
2013-12-17 17:19 ` Laurent Pinchart
2013-12-18 1:34 ` Simon Horman
2013-12-18 14:06 ` Laurent Pinchart
2013-12-19 6:12 ` Simon Horman
2013-12-19 6:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211151545.GB31617@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.