All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Samuel Bronson <naesten@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/2] cat-file: pass expand_data to print_object_or_die
Date: Wed, 11 Dec 2013 12:11:12 -0800	[thread overview]
Message-ID: <20131211201112.GM2311@google.com> (raw)
In-Reply-To: <20131211115642.GA10594@sigill.intra.peff.net>

Hi,

Jeff King wrote:

>                                        However, if we pass
> the whole struct, the called function can make more
> intelligent decisions about which fields were actualled
> filled by sha1_object_info.

Thanks.

s/actualled/actually/, I think.

At first I thought this patch was going to be about making those
intelligent decisions.  Maybe s/the called function can/a future patch
can teach the called function/ or something?

[...]
> There should be no functional change to this patch.

The patch itself looks straightforward, yep. :)

With the typofix mentioned above,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

  reply	other threads:[~2013-12-11 20:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11  4:37 [BUG] "echo HEAD | git cat-file --batch=''" fails catastrophically Samuel Bronson
2013-12-11 11:54 ` Jeff King
2013-12-11 11:56   ` [PATCH 1/2] cat-file: pass expand_data to print_object_or_die Jeff King
2013-12-11 20:11     ` Jonathan Nieder [this message]
2013-12-11 23:01       ` Jeff King
2013-12-12  3:03         ` Junio C Hamano
2013-12-11 11:58   ` [PATCH 2/2] cat-file: handle --batch format with missing type/size Jeff King
2013-12-11 20:42     ` Jonathan Nieder
2013-12-11 23:15       ` Jeff King
2013-12-11 23:31         ` Jonathan Nieder
2013-12-12  3:05         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211201112.GM2311@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=naesten@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.