All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Junho Ryu <jayr@google.com>,
	hughd@google.com, tytso@mit.edu, branto@redhat.com,
	xfs@oss.sgi.com
Subject: Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.
Date: Thu, 12 Dec 2013 09:40:12 +1100	[thread overview]
Message-ID: <20131211224012.GJ10988@dastard> (raw)
In-Reply-To: <20131211074615.GE19248@infradead.org>

On Tue, Dec 10, 2013 at 11:46:15PM -0800, Christoph Hellwig wrote:
> On Tue, Dec 10, 2013 at 12:11:56PM -0800, Junho Ryu wrote:
> > Several tests unmount then re-mount the scratch filesystem, to check
> > that the content is unchanged; but unmounting a tmpfs is designed to
> > lose its content, which causes such tests to fail unnecessarily.  Add
> > _scratch_remount(), which instead uses remount on a tmpfs to preserve
> > its contents.  Also add _test_remount() to do the same for the test
> > device.
> 
> All these tests don't make sense if you never unmount the filesystem.
> Istead they should exit with _notrun for tmpfs.

IOWs, adding tmpfs changes the definition of a "generic" test.

i.e. instead of:

_supported_fs generic

these tests are now:

_supported_fs xfs ext2 ext3 ext4 ext4dev btrfs gfs2 nfs udf reiserfs

and by that definition should be in the tests/shared directory....

That's a bit of a pain, but I really don't like the idea of having
"generic" tests that aren't actually generic by having to define
exceptions for them...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-12-11 22:40 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 20:11 [PATCH 00/10] Add tmpfs filesystem support Junho Ryu
2013-12-10 20:11 ` [PATCH 01/10] xfstests: Add tmpfs support Junho Ryu
2013-12-11  7:40   ` Christoph Hellwig
2013-12-17 16:40   ` Rich Johnston
2013-12-10 20:11 ` [PATCH 02/10] xfstests: use mount point instead of device name Junho Ryu
2013-12-11  7:42   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 03/10] xfstests: _scratch_mkfs_sized() for tmpfs Junho Ryu
2013-12-11  7:44   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 04/10] xfstests: increase tmpfs memory size Junho Ryu
2013-12-11  7:44   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 05/10] xfstests: do not unmount tmpfs during remount Junho Ryu
2013-12-11  7:46   ` Christoph Hellwig
2013-12-11 22:40     ` Dave Chinner [this message]
2013-12-12  0:16       ` Theodore Ts'o
2013-12-12  0:53         ` Dave Chinner
2013-12-12 18:01       ` Christoph Hellwig
2013-12-12 22:56         ` Dave Chinner
2013-12-13  0:00           ` Junho Ryu
2013-12-13  1:41             ` Dave Chinner
2013-12-13 11:12               ` Christoph Hellwig
2013-12-13  4:56           ` Theodore Ts'o
2013-12-13 11:04           ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 06/10] xfstests: fix generic/225 to check fiemap support Junho Ryu
2013-12-11  7:46   ` Christoph Hellwig
2013-12-11 22:42     ` Dave Chinner
2013-12-12 18:01       ` Christoph Hellwig
2013-12-12 22:44         ` Junho Ryu
2013-12-12 23:00           ` Dave Chinner
2013-12-10 20:11 ` [PATCH 07/10] xfstests: fix generic/127 to call _cleanup() only once Junho Ryu
2013-12-11  7:47   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 08/10] xfstests: check O_DIRECT support before testing direct I/O Junho Ryu
2013-12-11  7:47   ` Christoph Hellwig
2013-12-10 20:12 ` [PATCH 09/10] xfstests: add executable permission to tests Junho Ryu
2013-12-11  7:48   ` Christoph Hellwig
2013-12-10 20:12 ` [PATCH 10/10] xfstests: skip parts of tests which cannot work on tmpfs Junho Ryu
2013-12-11  7:51   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211224012.GJ10988@dastard \
    --to=david@fromorbit.com \
    --cc=branto@redhat.com \
    --cc=hch@infradead.org \
    --cc=hughd@google.com \
    --cc=jayr@google.com \
    --cc=tytso@mit.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.