All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>,
	xfs@oss.sgi.com
Subject: Re: [PATCH 00/12] run more generic tests on TEST_DIR
Date: Thu, 12 Dec 2013 09:50:12 +1100	[thread overview]
Message-ID: <20131211225012.GL10988@dastard> (raw)
In-Reply-To: <20131211073445.353655850@bombadil.infradead.org>

On Tue, Dec 10, 2013 at 11:34:45PM -0800, Christoph Hellwig wrote:
> As Stanislav pointed out previously various tests worked fine on NFS
> when it still defined a scratch dir that we abused for the test dir.
> 
> This series makes various tests that don't require specific file system
> sizes or parameters run on TEST_DIR instead of using the scratch devices.
> 
> This also allow to remove various bits of boilerplat code as the TEST_DIR
> is always available, and checked after each test.

I'm not sure this is such a good idea. The test_dir is a fixed
filesystem designed to persiste between test harness runs to allow
testing on an aged filesystem.

The scratch dev, OTOH, is used to give tests a known state before the test
begins, and to enable different filesystem configurations to be
tested easily. That is:

$ ./check -g auto

and

$ MKFS_OPTIONS="-b size=512" ./check -g auto

run the tests on a differently configured scratch device. I use this
all the time to change the filesystem config I'm testing against. By
moving all these tests to the TEST_DEV, these tests are no longer
run on the device that is configured specifically the way I want it
configured for the given test run.

So, I think this is a step backwards in terms of being able to
quickly iterate and cover different filesystem configurations, and
as such I don't really like it as a solution. What other options do
we have?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-12-11 22:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11  7:34 [PATCH 00/12] run more generic tests on TEST_DIR Christoph Hellwig
2013-12-11  7:34 ` [PATCH 01/12] 062: use TEST_DIR instead of a SCRATCH_DEV Christoph Hellwig
2013-12-11  7:34 ` [PATCH 02/12] 069: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 03/12] 079: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 04/12] 100: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 05/12] 105: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 06/12] 117: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 07/12] 124: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 08/12] 130: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 09/12] 132: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 10/12] 141: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 11/12] 225: " Christoph Hellwig
2013-12-11  7:34 ` [PATCH 12/12] 319: " Christoph Hellwig
2013-12-11 22:50 ` Dave Chinner [this message]
     [not found]   ` <20131212180312.GC19422@infradead.org>
2013-12-13  1:09     ` [PATCH 00/12] run more generic tests on TEST_DIR Dave Chinner
2013-12-13 11:10       ` Christoph Hellwig
2013-12-17 21:19         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211225012.GL10988@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=stanislav.kholmanskikh@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.