Re: [Qemu-devel] [PATCH RFC 2/2] rng-egd: introduce a parameter to set buffer size

[Amos Kong <akong@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

On Tue, Dec 10, 2013 at 09:58:19AM -0700, Eric Blake wrote:
> On 12/09/2013 07:10 AM, Amos Kong wrote:

Hi Eric,

> > This patch makes the buffer size configurable, the max
> > buffer size is 65536.
> > 
> >  -object rng-egd,chardev=chr0,id=rng0,buf_size=1024
> > 
> > Signed-off-by: Amos Kong <akong@redhat.com>
> > ---
> >  backends/rng-egd.c | 24 +++++++++++++++++++++---
> >  1 file changed, 21 insertions(+), 3 deletions(-)
> 
> > @@ -281,6 +298,7 @@ static void rng_egd_init(Object *obj)
> >      object_property_add_str(obj, "chardev",
> >                              rng_egd_get_chardev, rng_egd_set_chardev,
> >                              NULL);
> > +    object_property_add_str(obj, "buf_size", NULL, rng_egd_set_buf_size, NULL);
> >  }
> 
> Will libvirt ever need to set this property?  And is it easily
> discoverable whether qemu supports or lacks this property?

This is ajust a RFC patch, we might fix the performance with other
method. If it won't cost too much memory for buf, we can remove
this parameter.

In this patch, we have a default buffer size.
 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org



-- 
			Amos.

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]