All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xen.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Subject: [OSSTest PATCH 2/2] ts-debian-fixup: avoid removing the host root password
Date: Thu, 12 Dec 2013 13:37:01 +0100	[thread overview]
Message-ID: <20131212123701.31099.89171.stgit@Solace> (raw)
In-Reply-To: <20131212123239.31099.15104.stgit@Solace>

for the following reasons:
 - it's the guest's root password that was being targeted,
   the fact that we're killing the host's one is a bug;
 - it's not needed, as a few lines below we copy the rsa
   keys necessary to login without any password being
   prompet.

This has been tested by doing a full
$ ./sg-run-job test-amd64-amd64-xl

and, after that, restarting the guest and (successfully)
ssh-ing there.

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
 ts-debian-fixup |    1 -
 1 file changed, 1 deletion(-)

diff --git a/ts-debian-fixup b/ts-debian-fixup
index f001418..66c65a5 100755
--- a/ts-debian-fixup
+++ b/ts-debian-fixup
@@ -55,7 +55,6 @@ sub access () {
     target_cmd_root($ho, <<END);
         set -ex
         mount /dev/$gho->{Vg}/$gho->{Lv} /mnt
-        perl -i~ -pe "s/^root:[^:]+:/root::/" /etc/shadow
         mkdir -p /mnt/root/.ssh /mnt/etc/ssh
         cp -a /root/.ssh/* /mnt/root/.ssh/.
         cp -a /etc/ssh/ssh_host_*key* /mnt/etc/ssh/.

  parent reply	other threads:[~2013-12-12 12:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12 12:36 [OSSTest PATCH 0/2] Fix (minor) bugs in dir creation and root login Dario Faggioli
2013-12-12 12:36 ` [OSSTest PATCH 1/2] Use `mkdir -p' in a few more places Dario Faggioli
2013-12-12 12:37 ` Dario Faggioli [this message]
2013-12-12 16:27 ` [OSSTest PATCH 0/2] Fix (minor) bugs in dir creation and root login Ian Jackson
2013-12-12 16:34   ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212123701.31099.89171.stgit@Solace \
    --to=dario.faggioli@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.