Re: [PATCH] crash_dump: fix compilation error (on MIPS at least)

[Vivek Goyal <vgoyal@redhat.com>]

Generally akpm picks the kexec/kdump arch independent changes. 

Andrew, can you please consider this patch for inclusion.

Thanks
Vivek

On Wed, Dec 11, 2013 at 11:43:32AM +0000, Qais Yousef wrote:
> > -----Original Message-----
> > From: Vivek Goyal [mailto:vgoyal@redhat.com]
> > Sent: 05 December 2013 13:59
> > To: Qais Yousef
> > Cc: linux-kernel@vger.kernel.org; Andrew Morton; Michael Holzheu; linux-
> > mips@linux-mips.org; stable@vger.kernel.org
> > Subject: Re: [PATCH] crash_dump: fix compilation error (on MIPS at least)
> > 
> > On Wed, Dec 04, 2013 at 03:58:22PM +0000, Qais Yousef wrote:
> > >   In file included from kernel/crash_dump.c:2:0:
> > >   include/linux/crash_dump.h:22:27: error: unknown type name ‘pgprot_t’
> > >
> > > when CONFIG_CRASH_DUMP=y
> > >
> > > The error was traced back to this commit:
> > >
> > >   9cb218131de1 vmcore: introduce remap_oldmem_pfn_range()
> > >
> > > include <asm/pgtable.h> to get the missing definition
> > >
> > > Cc: Andrew Morton <akpm@linux-foundation.org>
> > > Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> > > Cc: Vivek Goyal <vgoyal@redhat.com>
> > > Cc: <linux-mips@linux-mips.org>
> > > Cc: <stable@vger.kernel.org> # 3.12
> > > Reviewed-by: James Hogan <james.hogan@imgtec.com>
> > > Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> > > ---
> > 
> > Looks good to me.
> > 
> > Acked-by: Vivek Goyal <vgoyal@redhat.com>
> > 
> > Vivek
> 
> Hi,
> 
> I failed to see this picked up by anyone. I'm not sure which tree it should go to to be honest. Do I need to add more people to the Cc? Or am I just being impatient? :)
> 
> Thanks,
> Qais
> 
> > 
> > > I haven't tried any other architecture except mips.
> > > If OK this should be considered for stable 3.12 (CCed).
> > >
> > >  include/linux/crash_dump.h |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> > > index fe68a5a..7032518 100644
> > > --- a/include/linux/crash_dump.h
> > > +++ b/include/linux/crash_dump.h
> > > @@ -6,6 +6,8 @@
> > >  #include <linux/proc_fs.h>
> > >  #include <linux/elf.h>
> > >
> > > +#include <asm/pgtable.h> /* for pgprot_t */
> > > +
> > >  #define ELFCORE_ADDR_MAX	(-1ULL)
> > >  #define ELFCORE_ADDR_ERR	(-2ULL)
> > >
> > > --
> > > 1.7.1
> > >