All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_metadump: Make -F (force) optional
Date: Thu, 12 Dec 2013 10:31:15 -0800	[thread overview]
Message-ID: <20131212183115.GA16378@infradead.org> (raw)
In-Reply-To: <52A9F6CF.1070300@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

> xfs_metadump will pass "-F" to xfs_db to carry on even in the face
> of bad superblock magic. [1]  Depending on what we gave as an input
> file, we may very well fail quite badly:
> 
> > xfs_metadump: /root/anaconda.cfg is not a valid XFS filesystem (unexpected SB magic number 0x230a2320)
> > Floating point exception
> 
> I don't think it's possible to harden every path through libxfs for
> non-xfs filesystems as input.  (Even if it's possible, I don't think it's
> worth the effort).

Can you add a test to verify that xfs_metadump now correctly rejects
files that don't have a valid superblock?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-12-12 18:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12 17:47 [PATCH] xfs_metadump: Make -F (force) optional Eric Sandeen
2013-12-12 18:31 ` Christoph Hellwig [this message]
2013-12-12 20:01   ` Eric Sandeen
2013-12-17 16:55     ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212183115.GA16378@infradead.org \
    --to=hch@infradead.org \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.