From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([2a01:4f8:120:8448::d00d]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VrDGy-0001Th-SU for kexec@lists.infradead.org; Thu, 12 Dec 2013 20:54:18 +0000 Date: Thu, 12 Dec 2013 21:53:46 +0100 From: Borislav Petkov Subject: Re: [PATCH v5 08/14] efi: export efi runtime memory mapping to sysfs Message-ID: <20131212205346.GA30162@pd.tnic> References: <1386582147-9802-1-git-send-email-dyoung@redhat.com> <1386582147-9802-9-git-send-email-dyoung@redhat.com> <20131211185520.GG23793@pd.tnic> <20131212023617.GF3751@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131212023617.GF3751@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, toshi.kani@hp.com, matt@console-pimps.org, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, ebiederm@xmission.com, hpa@zytor.com, vgoyal@redhat.com On Thu, Dec 12, 2013 at 10:36:17AM +0800, Dave Young wrote: > Sorry that I forgot to explain this in changelog, should ask you before. > > I did try moving it to efisubsys_init but it need add extern declaration So what? Add it. > for efi_runtime_map_init. Since link order will ensure it being called after > efisubsys_init I think it's fine with this static function. This is actually exactly the reason why it shouldn't be another subsys_initcall() if it can be helped. People would need to go have a look at drivers/firmware/efi/Makefile to realize that the link order is ok. And, this is prone to future breakage if people go and move code around and thereby change the link order. Please call efi_runtime_map_init from efisubsys_init. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v5 08/14] efi: export efi runtime memory mapping to sysfs Date: Thu, 12 Dec 2013 21:53:46 +0100 Message-ID: <20131212205346.GA30162@pd.tnic> References: <1386582147-9802-1-git-send-email-dyoung@redhat.com> <1386582147-9802-9-git-send-email-dyoung@redhat.com> <20131211185520.GG23793@pd.tnic> <20131212023617.GF3751@dhcp-16-126.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20131212023617.GF3751-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org List-Id: linux-efi@vger.kernel.org On Thu, Dec 12, 2013 at 10:36:17AM +0800, Dave Young wrote: > Sorry that I forgot to explain this in changelog, should ask you before. > > I did try moving it to efisubsys_init but it need add extern declaration So what? Add it. > for efi_runtime_map_init. Since link order will ensure it being called after > efisubsys_init I think it's fine with this static function. This is actually exactly the reason why it shouldn't be another subsys_initcall() if it can be helped. People would need to go have a look at drivers/firmware/efi/Makefile to realize that the link order is ok. And, this is prone to future breakage if people go and move code around and thereby change the link order. Please call efi_runtime_map_init from efisubsys_init. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915Ab3LLUx5 (ORCPT ); Thu, 12 Dec 2013 15:53:57 -0500 Received: from mail.skyhub.de ([78.46.96.112]:57817 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608Ab3LLUxz (ORCPT ); Thu, 12 Dec 2013 15:53:55 -0500 Date: Thu, 12 Dec 2013 21:53:46 +0100 From: Borislav Petkov To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, greg@kroah.com, matt@console-pimps.org, toshi.kani@hp.com Subject: Re: [PATCH v5 08/14] efi: export efi runtime memory mapping to sysfs Message-ID: <20131212205346.GA30162@pd.tnic> References: <1386582147-9802-1-git-send-email-dyoung@redhat.com> <1386582147-9802-9-git-send-email-dyoung@redhat.com> <20131211185520.GG23793@pd.tnic> <20131212023617.GF3751@dhcp-16-126.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20131212023617.GF3751@dhcp-16-126.nay.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2013 at 10:36:17AM +0800, Dave Young wrote: > Sorry that I forgot to explain this in changelog, should ask you before. > > I did try moving it to efisubsys_init but it need add extern declaration So what? Add it. > for efi_runtime_map_init. Since link order will ensure it being called after > efisubsys_init I think it's fine with this static function. This is actually exactly the reason why it shouldn't be another subsys_initcall() if it can be helped. People would need to go have a look at drivers/firmware/efi/Makefile to realize that the link order is ok. And, this is prone to future breakage if people go and move code around and thereby change the link order. Please call efi_runtime_map_init from efisubsys_init. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --