All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v2 3/8] xfs: get rid of XFS_IALLOC_BLOCKS macros
Date: Fri, 13 Dec 2013 09:09:53 +1100	[thread overview]
Message-ID: <20131212220953.GF10988@dastard> (raw)
In-Reply-To: <52A967E9.7070508@oracle.com>

On Thu, Dec 12, 2013 at 03:38:17PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
> 
> Get rid of XFS_IALLOC_BLOCKS() marcos, use mp->m_ialloc_blks directly.
> 
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
....
> @@ -1228,9 +1228,9 @@ xfs_difree(
>  			goto error0;
>  		}
>  
> -		xfs_bmap_add_free(XFS_AGB_TO_FSB(mp,
> -				agno, XFS_INO_TO_AGBNO(mp,rec.ir_startino)),
> -				XFS_IALLOC_BLOCKS(mp), flist, mp);
> +		xfs_bmap_add_free(XFS_AGB_TO_FSB(mp, agno,
> +				  XFS_INO_TO_AGBNO(mp, rec.ir_startino)),
> +				  mp->m_ialloc_blks, flist, mp);
>  	} else {
>  		*delete = 0;
>  

git-am fails to apply this hunk, but I'm not sure why. I updated it
manually, the resulting patch looks identical.

Other than that, it looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-12-12 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  7:38 [PATCH v2 3/8] xfs: get rid of XFS_IALLOC_BLOCKS macros Jeff Liu
2013-12-12 22:09 ` Dave Chinner [this message]
2013-12-13  2:44   ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212220953.GF10988@dastard \
    --to=david@fromorbit.com \
    --cc=jeff.liu@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.