From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
dmitry.torokhov@gmail.com, Ian Campbell <Ian.Campbell@citrix.com>,
david.vrabel@citrix.com
Subject: Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.
Date: Thu, 12 Dec 2013 20:34:15 -0500 [thread overview]
Message-ID: <20131213013415.GC2697@pegasus.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312121128260.7093@kaball.uk.xensource.com>
>
> I think that the patch is good, the main issue is that it is missing the
> ARM and ARM64 implementations of xen_has_pv_devices & co.
I think that is OK - you don't have CONFIG_PVHVM so from the platform_pci.h
the 'static inline' ones get picked up which will return true (except the
xen_has_pv_block_and_legacy_devices which will return false) for all of
those functions (if compiled with CONFIG_XEN).
It should compile _and_ work properly.
.. snip..
> __xen_has_pv_device should be static
Yes. Thanks for spotting that!
>
next prev parent reply other threads:[~2013-12-13 1:35 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 21:14 [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up Konrad Rzeszutek Wilk
2013-12-03 21:14 ` Konrad Rzeszutek Wilk
2013-12-04 0:03 ` Matthew Daley
2013-12-04 0:03 ` [Xen-devel] " Matthew Daley
2013-12-04 0:03 ` Matthew Daley
2013-12-04 9:37 ` Ian Campbell
2013-12-04 9:37 ` Ian Campbell
2013-12-04 9:37 ` Ian Campbell
2013-12-04 9:37 ` Ian Campbell
2013-12-04 10:51 ` Stefano Stabellini
2013-12-04 10:51 ` Stefano Stabellini
2013-12-04 10:51 ` Stefano Stabellini
2013-12-04 10:51 ` Stefano Stabellini
2013-12-04 10:59 ` Ian Campbell
2013-12-04 10:59 ` Ian Campbell
2013-12-04 10:59 ` Ian Campbell
2013-12-04 10:59 ` Ian Campbell
2013-12-04 11:05 ` Stefano Stabellini
2013-12-04 11:05 ` Stefano Stabellini
2013-12-04 11:05 ` Stefano Stabellini
2013-12-04 11:05 ` Stefano Stabellini
2013-12-04 11:08 ` Ian Campbell
2013-12-04 11:08 ` Ian Campbell
2013-12-04 11:08 ` Ian Campbell
2013-12-04 11:18 ` Stefano Stabellini
2013-12-04 11:18 ` Stefano Stabellini
2013-12-04 11:18 ` Stefano Stabellini
2013-12-04 11:23 ` Ian Campbell
2013-12-04 11:23 ` Ian Campbell
2013-12-04 11:23 ` Ian Campbell
2013-12-04 11:23 ` Ian Campbell
2013-12-11 20:26 ` Konrad Rzeszutek Wilk
2013-12-12 10:43 ` Ian Campbell
2013-12-13 1:29 ` Konrad Rzeszutek Wilk
2013-12-13 9:58 ` Fabio Fantoni
2013-12-13 14:39 ` Konrad Rzeszutek Wilk
2013-12-12 11:30 ` Stefano Stabellini
2013-12-13 1:34 ` Konrad Rzeszutek Wilk [this message]
2013-12-13 20:18 ` Konrad Rzeszutek Wilk
2013-12-16 12:01 ` Stefano Stabellini
2013-12-04 11:18 ` Stefano Stabellini
2013-12-04 11:08 ` Ian Campbell
2013-12-04 10:48 ` Stefano Stabellini
2013-12-04 10:48 ` Stefano Stabellini
2013-12-04 10:48 ` Stefano Stabellini
2013-12-04 10:48 ` Stefano Stabellini
2013-12-04 13:00 ` David Vrabel
2013-12-04 13:00 ` David Vrabel
2013-12-04 13:00 ` David Vrabel
2013-12-04 13:06 ` Ian Campbell
2013-12-04 13:06 ` Ian Campbell
2013-12-04 13:06 ` Ian Campbell
2013-12-04 13:06 ` Ian Campbell
2013-12-04 13:00 ` David Vrabel
2013-12-04 16:42 ` Dmitry Torokhov
2013-12-04 16:42 ` Dmitry Torokhov
2013-12-04 16:42 ` Dmitry Torokhov
2013-12-04 16:48 ` Konrad Rzeszutek Wilk
2013-12-04 16:48 ` Konrad Rzeszutek Wilk
2013-12-04 17:08 ` Dmitry Torokhov
2013-12-04 17:08 ` Dmitry Torokhov
2013-12-04 17:08 ` Dmitry Torokhov
2013-12-04 16:48 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213013415.GC2697@pegasus.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=dmitry.torokhov@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.