All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serge Hallyn <serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
To: Libo Chen <clbchenlibo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	stgraber-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] lxc-user-nic: fix the wrong use of realloc
Date: Thu, 12 Dec 2013 22:24:01 -0600	[thread overview]
Message-ID: <20131213042401.GA26399@tp> (raw)
In-Reply-To: <52AA8471.9010706-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

Quoting Libo Chen (clbchenlibo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org):
> fix the wrong use of realloc
> 
> Signed-off-by: Libo Chen <clbchenlibo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

Embarassing.  Thanks.

Acked-by: Serge E. Hallyn <serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>

> ---
>  src/lxc/lxc_user_nic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lxc/lxc_user_nic.c b/src/lxc/lxc_user_nic.c
> index caa411a..ac7a242 100644
> --- a/src/lxc/lxc_user_nic.c
> +++ b/src/lxc/lxc_user_nic.c
> @@ -318,7 +318,7 @@ static bool cull_entries(int fd, char *me, char *t, char *br)
>  	p = buf;
>  	e = buf + len;
>  	while ((p = find_line(p, e, me, t, br)) != NULL) {
> -		struct entry_line *newe = realloc(entry_lines, n+1);
> +		struct entry_line *newe = realloc(entry_lines, sizeof(*entry_lines)*(n+1));
>  		if (!newe) {
>  			free(entry_lines);
>  			return false;
> -- 
> 1.8.2.2
> 

      parent reply	other threads:[~2013-12-13  4:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13  3:52 [PATCH] lxc-user-nic: fix the wrong use of realloc Libo Chen
     [not found] ` <52AA8471.9010706-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-12-13  4:24   ` Serge Hallyn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131213042401.GA26399@tp \
    --to=serge.hallyn-gewih/nmzzlqt0dzr+alfa@public.gmane.org \
    --cc=clbchenlibo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=stgraber-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.