From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?iso-8859-1?q?St=FCbner?= Subject: Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX. Date: Fri, 13 Dec 2013 09:42:03 +0100 Message-ID: <201312130942.03674.heiko@sntech.de> References: <1378889173-7437-1-git-send-email-jose.goncalves@inov.pt> <52AA6909.8050200@inov.pt> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from gloria.sntech.de ([95.129.55.99]:36042 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834Ab3LMImP (ORCPT ); Fri, 13 Dec 2013 03:42:15 -0500 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: =?iso-8859-1?q?Jos=E9_Miguel_Gon=E7alves?= , Ben Dooks , Kukjin Kim , Tomasz Figa , linux-samsung-soc , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Am Freitag, 13. Dezember 2013, 09:12:52 schrieb Linus Walleij: > On Fri, Dec 13, 2013 at 2:55 AM, Jos=E9 Miguel Gon=E7alves >=20 > wrote: > > On 27-09-2013 15:17, Linus Walleij wrote: > >> On Wed, Sep 11, 2013 at 10:46 AM, Jos=E9 Miguel Gon=E7alves > >>=20 > >> wrote: > >>> Some GPIO line limits are incorrectly set which, for instance, > >>> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip. > >>>=20 > >>> Signed-off-by: Jos=E9 Miguel Gon=E7alves > >>> --- > >>>=20 > >>> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++----- >=20 > (...) >=20 > > Was this patch forgotten? >=20 > Not by me, I just never got an ACK from the Samsung maintainers, > so I can't apply it to the GPIO tree. >=20 > Ben, Kukjin: can one of you ACK this so I can take it through the > GPIO tree? again not the maintainer :-), but I've looked through the manuals of s3= c24xx=20 socs and the new values look correct [I had looked up the patch content= in the=20 list archive], so Acked-by: Heiko Stuebner But Jose, you should really really look into moving to devicetree with = your=20 platform, if you're not already doing so. Pinctrl support is already pr= esent,=20 and I'm hopefull the move to the common clock framework I posted a few = days=20 ago might make it too. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898Ab3LMImR (ORCPT ); Fri, 13 Dec 2013 03:42:17 -0500 Received: from gloria.sntech.de ([95.129.55.99]:36042 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834Ab3LMImP (ORCPT ); Fri, 13 Dec 2013 03:42:15 -0500 From: Heiko =?iso-8859-1?q?St=FCbner?= To: Linus Walleij Subject: Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX. Date: Fri, 13 Dec 2013 09:42:03 +0100 User-Agent: KMail/1.13.7 (Linux/3.2.0-3-686-pae; KDE/4.8.4; i686; ; ) Cc: =?iso-8859-1?q?Jos=E9_Miguel_Gon=E7alves?= , Ben Dooks , Kukjin Kim , Tomasz Figa , "linux-samsung-soc" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1378889173-7437-1-git-send-email-jose.goncalves@inov.pt> <52AA6909.8050200@inov.pt> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Message-Id: <201312130942.03674.heiko@sntech.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 13. Dezember 2013, 09:12:52 schrieb Linus Walleij: > On Fri, Dec 13, 2013 at 2:55 AM, José Miguel Gonçalves > > wrote: > > On 27-09-2013 15:17, Linus Walleij wrote: > >> On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves > >> > >> wrote: > >>> Some GPIO line limits are incorrectly set which, for instance, > >>> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip. > >>> > >>> Signed-off-by: José Miguel Gonçalves > >>> --- > >>> > >>> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++----- > > (...) > > > Was this patch forgotten? > > Not by me, I just never got an ACK from the Samsung maintainers, > so I can't apply it to the GPIO tree. > > Ben, Kukjin: can one of you ACK this so I can take it through the > GPIO tree? again not the maintainer :-), but I've looked through the manuals of s3c24xx socs and the new values look correct [I had looked up the patch content in the list archive], so Acked-by: Heiko Stuebner But Jose, you should really really look into moving to devicetree with your platform, if you're not already doing so. Pinctrl support is already present, and I'm hopefull the move to the common clock framework I posted a few days ago might make it too. Heiko