From: Martin Jansa <martin.jansa@gmail.com>
To: Chris Larson <kergoth@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [RFC 1/2] os-release: add new operating system identification recipe
Date: Fri, 13 Dec 2013 17:33:48 +0100 [thread overview]
Message-ID: <20131213163348.GE3715@jama> (raw)
In-Reply-To: <CABcZAN=usCwUpjWFy2G9D2VPUAhPhBFCVRp0UzVpg6=Lks3goQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Fri, Dec 13, 2013 at 08:12:51AM -0700, Chris Larson wrote:
> On Fri, Dec 13, 2013 at 8:08 AM, Martin Jansa <martin.jansa@gmail.com>wrote:
>
> > > +do_compile () {
> > > + for field in ${OS_RELEASE_FIELDS}; do
> > > + if eval "test -n \"\$$field\""; then
> > > + eval "printf \"%s=%s\n\" \"\$field\" \"\$$field\""
> > > + fi
> > > + done >os-release
> > > +}
> > > +do_compile[vardeps] += "${OS_RELEASE_FIELDS}"
> >
> > Isn't this dependency picked automatically?
> >
>
> No, this is expanded, so this adds the dependency on the variables whose
> names are in the OS_RELEASE_FIELDS variable, not just on OS_RELEASE_FIELDS
> itself. Due to the use of eval, bitbake doesn’t know we’re using the
> iterated values as variable names.
Ah I see, thanks for explanation.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-12-13 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 14:56 [RFC PATCH 0/2] Add /etc/os-release Christopher Larson
2013-12-13 14:56 ` [RFC 1/2] os-release: add new operating system identification recipe Christopher Larson
2013-12-13 15:08 ` Martin Jansa
2013-12-13 15:12 ` Chris Larson
2013-12-13 15:18 ` Chris Larson
2013-12-13 16:33 ` Martin Jansa [this message]
2013-12-13 15:56 ` Mark Hatle
2013-12-13 16:14 ` Chris Larson
2013-12-13 16:30 ` Koen Kooi
2013-12-13 16:27 ` Enrico Scholz
2013-12-13 16:31 ` Koen Kooi
2013-12-13 14:56 ` [RFC 2/2] systemd: rrecommend os-release Christopher Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213163348.GE3715@jama \
--to=martin.jansa@gmail.com \
--cc=kergoth@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.