From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 14 Dec 2013 13:27:54 +0100 Subject: [U-Boot] [PATCH V2 3/4] ARM: mx6: Add PCI express driver In-Reply-To: References: <1386996929-7085-1-git-send-email-marex@denx.de> <201312140633.00823.marex@denx.de> Message-ID: <201312141327.54338.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday, December 14, 2013 at 09:52:21 AM, Jagan Teki wrote: > On Sat, Dec 14, 2013 at 11:03 AM, Marek Vasut wrote: > > On Saturday, December 14, 2013 at 06:23:30 AM, Jagan Teki wrote: > > [...] > > > >> > +/* > >> > + * Replace the original ARM DABT handler with a simple jump-back one. > >> > + * > >> > + * The problem here is that if we have a PCIe bridge attached to this > >> > PCIe + * controller, but no PCIe device is connected to the bridges' > >> > downstream + * port, the attempt to read/write from/to the config > >> > space will produce + * a DABT. This is a behavior of the controller > >> > and can not be disabled + * unfortuatelly. > >> > + * > >> > + * To work around the problem, we backup the current DABT handler > >> > address + * and replace it with our own DABT handler, which only > >> > bounces right back + * into the code. > >> > + */ > >> > +static void imx_pcie_fix_dabt_handler(bool set) > >> > +{ > >> > + extern uint32_t *_data_abort; > >> > >> Not a good idea to use extern in .c - any comments? > > > > Why is half of the CC dropped from this email? (restored by hand) > > Sorry, some accident. > > > As for the extern, there is no better way to replace the DABT handler > > (see patch 0001) for this purpose . This will be changed later though, > > once Alberts' patches land , but that's a post-2014.01 matter. > > OK. > > And one more thing, where is the patch V2, 1/4 - I couldn't find it. Nowhere, 1/4 didn't change. Best regards, Marek Vasut