From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: clps711x: Add CLPS711X irqchip driver
Date: Sat, 14 Dec 2013 13:31:39 +0100 [thread overview]
Message-ID: <201312141331.39372.arnd@arndb.de> (raw)
In-Reply-To: <20131214092715.6735074a15ce6128d128875f@mail.ru>
On Saturday 14 December 2013, Alexander Shiyan wrote:
> On Sat, 7 Dec 2013 17:14:25 +0100
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Saturday 07 December 2013, Alexander Shiyan wrote:
> > > > > +void __init clps711x_intc_init(phys_addr_t base, resource_size_t size)
> > > > > +{
> > > > > + BUG_ON(_clps711x_intc_init(NULL, base, size));
> > > > > +}
> > > > > +EXPORT_SYMBOL(clps711x_intc_init);
> > > >
> > > > No need to export this symbol, because you don't call the function from
> > > > loadable modules.
> > >
> > > OK. I will remove it in the next version by adding "maybe_unused" to this
> > > function to avoid possible warnings.
> >
> > The __maybe_unused should not be needed, as the function will still have
> > global scope.
>
> Arnd can you merge this series with manual EXPORT_SYMBOL removal? Resend?
I'm still traveling at the moment and will only be resuming my normal arm-soc
work in January. All arm-soc patches are handled by Olof and Kevin still,
and irqchip patches go through Thomas anyway (or can get merged through arm-soc
with his Ack in case of dependencies).
Arnd
next prev parent reply other threads:[~2013-12-14 12:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 18:14 [PATCH 1/3] ARM: clps711x: Add CLPS711X irqchip driver Alexander Shiyan
2013-12-02 18:14 ` [PATCH 3/3] ARM: clps711x: Migrate CLPS711X subarch to the new " Alexander Shiyan
2013-12-07 14:30 ` Arnd Bergmann
2013-12-07 14:30 ` [PATCH 1/3] ARM: clps711x: Add CLPS711X " Arnd Bergmann
2013-12-07 14:40 ` Alexander Shiyan
2013-12-07 16:14 ` Arnd Bergmann
2013-12-07 16:27 ` Alexander Shiyan
2013-12-14 5:27 ` Alexander Shiyan
2013-12-14 12:31 ` Arnd Bergmann [this message]
2013-12-18 16:35 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312141331.39372.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.