Re: [PATCH 1/3] drivers: edac: Mark the function amd64_decode_bus_error() as static in amd64_edac.c

[Josh Triplett <josh@joshtriplett.org>]

On Sat, Dec 14, 2013 at 07:28:24PM +0530, Rashika Kheria wrote:
> This patch marks the function amd64_decode_bus_error() as static in
> amd64_edac.c because it is not used outside this file.
> 
> Thus, it also eliminates the following warning in amd64_edac.c:
> drivers/edac/amd64_edac.c:2038:6: warning: no previous prototype for ‘amd64_decode_bus_error’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/edac/amd64_edac.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index b53d0de..52b34ea 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -2035,7 +2035,7 @@ static inline void __amd64_decode_bus_error(struct mem_ctl_info *mci,
>  	__log_bus_error(mci, &err, ecc_type);
>  }
>  
> -void amd64_decode_bus_error(int node_id, struct mce *m)
> +static void amd64_decode_bus_error(int node_id, struct mce *m)
>  {
>  	__amd64_decode_bus_error(mcis[node_id], m);
>  }
> -- 
> 1.7.9.5
>