From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] drivers: pnp: Mark the function pnp_build_option() as static in resource.c
Date: Sat, 14 Dec 2013 12:58:37 -0800 [thread overview]
Message-ID: <20131214205836.GU17601@leaf> (raw)
In-Reply-To: <20131214132056.GA8624@rashika>
On Sat, Dec 14, 2013 at 06:50:56PM +0530, Rashika Kheria wrote:
> This patch marks the function pnp_build_option() as static in resource.c
> because it is not used outside this file.
>
> Thus, it also eliminates the following warning in resource.c:
> drivers/pnp/resource.c:34:20: warning: no previous prototype for ‘pnp_build_option’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/pnp/resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
> index d95e101..bacddd1 100644
> --- a/drivers/pnp/resource.c
> +++ b/drivers/pnp/resource.c
> @@ -31,7 +31,7 @@ static int pnp_reserve_mem[16] = {[0 ... 15] = -1 }; /* reserve (don't use) some
> * option registration
> */
>
> -struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
> +static struct pnp_option *pnp_build_option(struct pnp_dev *dev, unsigned long type,
> unsigned int option_flags)
> {
> struct pnp_option *option;
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-12-14 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 13:20 [PATCH] drivers: pnp: Mark the function pnp_build_option() as static in resource.c Rashika Kheria
2013-12-14 20:58 ` Josh Triplett [this message]
2014-01-05 23:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214205836.GU17601@leaf \
--to=josh@joshtriplett.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.