From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libext2fs: clamp block-map punch range end to 2^32 blocks
Date: Sat, 14 Dec 2013 19:48:58 -0500 [thread overview]
Message-ID: <20131215004858.GA15593@thunk.org> (raw)
In-Reply-To: <20131212211325.10844.50409.stgit@birch.djwong.org>
On Thu, Dec 12, 2013 at 01:13:25PM -0800, Darrick J. Wong wrote:
> In the ^extent case, passing ~0ULL as the 'end' parameter to
> ext2fs_punch() causes the (end - start + 1) calculation to overflow to
> zero. Since the old-style mapped block files cannot have more than
> 2^32 blocks, just clamp it to ~0U.
>
> This fixes a regression in t_quota_2off with the patch "libext2fs: use
> ext2fs_punch() to truncate quota file" applied.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2013-12-15 1:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 21:13 [PATCH] libext2fs: clamp block-map punch range end to 2^32 blocks Darrick J. Wong
2013-12-15 0:48 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131215004858.GA15593@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.