All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Kazuya Mio <k-mio@sx.jp.nec.com>
Cc: Andreas Dilger <adilger@dilger.ca>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH V4] mke2fs: disallow creating FS on a loop mounted file with no option
Date: Mon, 16 Dec 2013 00:49:16 -0500	[thread overview]
Message-ID: <20131216054916.GL28536@thunk.org> (raw)
In-Reply-To: <527B309D.4090706@sx.jp.nec.com>

On Thu, Nov 07, 2013 at 03:18:05PM +0900, Kazuya Mio wrote:
> When /etc/mtab is a symlink of /proc/mounts, mke2fs without -FF option
> can create a filesystem on the image file that is mounted.
> According to mke2fs man page, we should specify -FF option in this case.
> 
> This patch protects filesystem from unintended mke2fs caused by human error.
> 
> How to reproduce:
>   # mke2fs -t ext4 -Fq fs.img
>   # mount -o loop fs.img /mnt/mp1
>   # mke2fs -t ext4 -Fq fs.img && echo "mke2fs success"
>   mke2fs success
> 
> Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>

Thanks, applied.

						- Ted

      parent reply	other threads:[~2013-12-16  5:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07  6:18 [PATCH V4] mke2fs: disallow creating FS on a loop mounted file with no option Kazuya Mio
2013-11-29  6:25 ` Kazuya Mio
2013-11-30 20:35   ` Darrick J. Wong
2013-12-16  5:49 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131216054916.GL28536@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=k-mio@sx.jp.nec.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.