From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c Date: Mon, 16 Dec 2013 06:23:38 -0800 Message-ID: <20131216142338.GA24172@leaf> References: <20131216112408.GA4896@rashika> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20131216112408.GA4896@rashika> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rashika Kheria Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" List-Id: virtualization@lists.linuxfoundation.org T24gTW9uLCBEZWMgMTYsIDIwMTMgYXQgMDQ6NTQ6MDhQTSArMDUzMCwgUmFzaGlrYSBLaGVyaWEg d3JvdGU6Cj4gTWFyayB0aGUgZnVuY3Rpb24gdmlydGJhbGxvb25fbWlncmF0ZXBhZ2UoKSBhcyBz dGF0aWMgaW4KPiB2aXJ0aW9fYmFsbG9vbi5jIGJlY2F1c2UgaXQgaXMgbm90IHVzZWQgb3V0c2lk ZSB0aGlzIGZpbGUuCj4gCj4gVGhpcyBlbGltaW5hdGVzIHRoZSBmb2xsb3dpbmcgd2FybmluZyBp biB2aXJ0aW9fYmFsbG9vbi5jOgo+IGRyaXZlcnMvdmlydGlvL3ZpcnRpb19iYWxsb29uLmM6Mzcy OjU6IHdhcm5pbmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig4oCYdmlydGJhbGxvb25fbWln cmF0ZXBhZ2XigJkgWy1XbWlzc2luZy1wcm90b3R5cGVzXQo+IAo+IFNpZ25lZC1vZmYtYnk6IFJh c2hpa2EgS2hlcmlhIDxyYXNoaWthLmtoZXJpYUBnbWFpbC5jb20+CgpSZXZpZXdlZC1ieTogSm9z aCBUcmlwbGV0dCA8am9zaEBqb3NodHJpcGxldHQub3JnPgoKPiAgZHJpdmVycy92aXJ0aW8vdmly dGlvX2JhbGxvb24uYyB8ICAgIDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19i YWxsb29uLmMgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fYmFsbG9vbi5jCj4gaW5kZXggYzQ0NDY1 NC4uOGM1OTQzZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZpcnRpby92aXJ0aW9fYmFsbG9vbi5j Cj4gKysrIGIvZHJpdmVycy92aXJ0aW8vdmlydGlvX2JhbGxvb24uYwo+IEBAIC0zNjksNyArMzY5 LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBhZGRyZXNzX3NwYWNlX29wZXJhdGlvbnMgdmlydGlv X2JhbGxvb25fYW9wczsKPiAgICogVGhpcyBmdW5jdGlvbiBwcmVmb3JtcyB0aGUgYmFsbG9vbiBw YWdlIG1pZ3JhdGlvbiB0YXNrLgo+ICAgKiBDYWxsZWQgdGhyb3VnaCBiYWxsb29uX21hcHBpbmct PmFfb3BzLT5taWdyYXRlcGFnZQo+ICAgKi8KPiAtaW50IHZpcnRiYWxsb29uX21pZ3JhdGVwYWdl KHN0cnVjdCBhZGRyZXNzX3NwYWNlICptYXBwaW5nLAo+ICtzdGF0aWMgaW50IHZpcnRiYWxsb29u X21pZ3JhdGVwYWdlKHN0cnVjdCBhZGRyZXNzX3NwYWNlICptYXBwaW5nLAo+ICAJCXN0cnVjdCBw YWdlICpuZXdwYWdlLCBzdHJ1Y3QgcGFnZSAqcGFnZSwgZW51bSBtaWdyYXRlX21vZGUgbW9kZSkK PiAgewo+ICAJc3RydWN0IGJhbGxvb25fZGV2X2luZm8gKnZiX2Rldl9pbmZvID0gYmFsbG9vbl9w YWdlX2RldmljZShwYWdlKTsKPiAtLSAKPiAxLjcuOS41Cj4gCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApW aXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxp bnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754418Ab3LPOXs (ORCPT ); Mon, 16 Dec 2013 09:23:48 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47896 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754384Ab3LPOXr convert rfc822-to-8bit (ORCPT ); Mon, 16 Dec 2013 09:23:47 -0500 X-Originating-IP: 50.43.14.201 Date: Mon, 16 Dec 2013 06:23:38 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Rusty Russell , "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org Subject: Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c Message-ID: <20131216142338.GA24172@leaf> References: <20131216112408.GA4896@rashika> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20131216112408.GA4896@rashika> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote: > Mark the function virtballoon_migratepage() as static in > virtio_balloon.c because it is not used outside this file. > > This eliminates the following warning in virtio_balloon.c: > drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/virtio/virtio_balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index c444654..8c5943d 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops; > * This function preforms the balloon page migration task. > * Called through balloon_mapping->a_ops->migratepage > */ > -int virtballoon_migratepage(struct address_space *mapping, > +static int virtballoon_migratepage(struct address_space *mapping, > struct page *newpage, struct page *page, enum migrate_mode mode) > { > struct balloon_dev_info *vb_dev_info = balloon_page_device(page); > -- > 1.7.9.5 >