From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c Date: Mon, 16 Dec 2013 16:29:11 +0200 Message-ID: <20131216142911.GA21241@redhat.com> References: <20131216112408.GA4896@rashika> <20131216142338.GA24172@leaf> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20131216142338.GA24172@leaf> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Josh Triplett Cc: Rashika Kheria , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org T24gTW9uLCBEZWMgMTYsIDIwMTMgYXQgMDY6MjM6MzhBTSAtMDgwMCwgSm9zaCBUcmlwbGV0dCB3 cm90ZToKPiBPbiBNb24sIERlYyAxNiwgMjAxMyBhdCAwNDo1NDowOFBNICswNTMwLCBSYXNoaWth IEtoZXJpYSB3cm90ZToKPiA+IE1hcmsgdGhlIGZ1bmN0aW9uIHZpcnRiYWxsb29uX21pZ3JhdGVw YWdlKCkgYXMgc3RhdGljIGluCj4gPiB2aXJ0aW9fYmFsbG9vbi5jIGJlY2F1c2UgaXQgaXMgbm90 IHVzZWQgb3V0c2lkZSB0aGlzIGZpbGUuCj4gPiAKPiA+IFRoaXMgZWxpbWluYXRlcyB0aGUgZm9s bG93aW5nIHdhcm5pbmcgaW4gdmlydGlvX2JhbGxvb24uYzoKPiA+IGRyaXZlcnMvdmlydGlvL3Zp cnRpb19iYWxsb29uLmM6MzcyOjU6IHdhcm5pbmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig 4oCYdmlydGJhbGxvb25fbWlncmF0ZXBhZ2XigJkgWy1XbWlzc2luZy1wcm90b3R5cGVzXQo+ID4g Cj4gPiBTaWduZWQtb2ZmLWJ5OiBSYXNoaWthIEtoZXJpYSA8cmFzaGlrYS5raGVyaWFAZ21haWwu Y29tPgo+IAo+IFJldmlld2VkLWJ5OiBKb3NoIFRyaXBsZXR0IDxqb3NoQGpvc2h0cmlwbGV0dC5v cmc+CgpBY2tlZC1ieTogTWljaGFlbCBTLiBUc2lya2luIDxtc3RAcmVkaGF0LmNvbT4KCj4gPiAg ZHJpdmVycy92aXJ0aW8vdmlydGlvX2JhbGxvb24uYyB8ICAgIDIgKy0KPiA+ICAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvdmlydGlvL3ZpcnRpb19iYWxsb29uLmMgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW9f YmFsbG9vbi5jCj4gPiBpbmRleCBjNDQ0NjU0Li44YzU5NDNkIDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy92aXJ0aW8vdmlydGlvX2JhbGxvb24uYwo+ID4gKysrIGIvZHJpdmVycy92aXJ0aW8vdmly dGlvX2JhbGxvb24uYwo+ID4gQEAgLTM2OSw3ICszNjksNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IGFkZHJlc3Nfc3BhY2Vfb3BlcmF0aW9ucyB2aXJ0aW9fYmFsbG9vbl9hb3BzOwo+ID4gICAqIFRo aXMgZnVuY3Rpb24gcHJlZm9ybXMgdGhlIGJhbGxvb24gcGFnZSBtaWdyYXRpb24gdGFzay4KPiA+ ICAgKiBDYWxsZWQgdGhyb3VnaCBiYWxsb29uX21hcHBpbmctPmFfb3BzLT5taWdyYXRlcGFnZQo+ ID4gICAqLwo+ID4gLWludCB2aXJ0YmFsbG9vbl9taWdyYXRlcGFnZShzdHJ1Y3QgYWRkcmVzc19z cGFjZSAqbWFwcGluZywKPiA+ICtzdGF0aWMgaW50IHZpcnRiYWxsb29uX21pZ3JhdGVwYWdlKHN0 cnVjdCBhZGRyZXNzX3NwYWNlICptYXBwaW5nLAo+ID4gIAkJc3RydWN0IHBhZ2UgKm5ld3BhZ2Us IHN0cnVjdCBwYWdlICpwYWdlLCBlbnVtIG1pZ3JhdGVfbW9kZSBtb2RlKQo+ID4gIHsKPiA+ICAJ c3RydWN0IGJhbGxvb25fZGV2X2luZm8gKnZiX2Rldl9pbmZvID0gYmFsbG9vbl9wYWdlX2Rldmlj ZShwYWdlKTsKPiA+IC0tIAo+ID4gMS43LjkuNQo+ID4gCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0 dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4 Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754096Ab3LPOZa (ORCPT ); Mon, 16 Dec 2013 09:25:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25552 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753285Ab3LPOZ3 (ORCPT ); Mon, 16 Dec 2013 09:25:29 -0500 Date: Mon, 16 Dec 2013 16:29:11 +0200 From: "Michael S. Tsirkin" To: Josh Triplett Cc: Rashika Kheria , linux-kernel@vger.kernel.org, Rusty Russell , virtualization@lists.linux-foundation.org Subject: Re: [PATCH] drivers: virtio: Mark function virtballoon_migratepage() as static in virtio_balloon.c Message-ID: <20131216142911.GA21241@redhat.com> References: <20131216112408.GA4896@rashika> <20131216142338.GA24172@leaf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20131216142338.GA24172@leaf> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2013 at 06:23:38AM -0800, Josh Triplett wrote: > On Mon, Dec 16, 2013 at 04:54:08PM +0530, Rashika Kheria wrote: > > Mark the function virtballoon_migratepage() as static in > > virtio_balloon.c because it is not used outside this file. > > > > This eliminates the following warning in virtio_balloon.c: > > drivers/virtio/virtio_balloon.c:372:5: warning: no previous prototype for ‘virtballoon_migratepage’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett Acked-by: Michael S. Tsirkin > > drivers/virtio/virtio_balloon.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > > index c444654..8c5943d 100644 > > --- a/drivers/virtio/virtio_balloon.c > > +++ b/drivers/virtio/virtio_balloon.c > > @@ -369,7 +369,7 @@ static const struct address_space_operations virtio_balloon_aops; > > * This function preforms the balloon page migration task. > > * Called through balloon_mapping->a_ops->migratepage > > */ > > -int virtballoon_migratepage(struct address_space *mapping, > > +static int virtballoon_migratepage(struct address_space *mapping, > > struct page *newpage, struct page *page, enum migrate_mode mode) > > { > > struct balloon_dev_info *vb_dev_info = balloon_page_device(page); > > -- > > 1.7.9.5 > >