Re: [Qemu-devel] [PATCH 04/11] qdev: add to BusState "hotplug-handler" link

[Igor Mammedov <imammedo@redhat.com>]

On Mon, 16 Dec 2013 16:26:25 +0100
Igor Mammedov <imammedo@redhat.com> wrote:

> On Sat, 14 Dec 2013 17:05:57 +1000
> Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
> 
[...]
> > >
> > >      QTAILQ_INIT(&bus->children);
> > > +    object_property_add_link(obj, QDEV_HOTPLUG_HANDLER_PROPERTY,
> > > +                             TYPE_HOTPLUG_HANDLER,
> > > +                             (Object **)&bus->hotplug_handler, NULL);
> > 
> > I think failure of this is fatal. When the patches go through,
> > probably want to &error_abort.
[...]
> 
> But more to the point, bus could be created during hotplug, and
> we do not want to abort guest, instead hotplug operation should fail.
> In this case following setting of QDEV_HOTPLUG_HANDLER_PROPERTY
> will fail if object_property_add_link() failed before.

In following patches there is a couple places asking for being replaced
with &error_abort, so if your patches get in before respin, I'll gladly
use &error_abort there.