From: Thierry Reding <thierry.reding@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
Linus Walleij <linus.walleij@linaro.org>,
Arun Murthy <arun.murthy@stericsson.com>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: ab8500: Fix wrong value shift for disable/enable pwm
Date: Tue, 17 Dec 2013 10:30:50 +0100 [thread overview]
Message-ID: <20131217093049.GA13823@ulmo.nvidia.com> (raw)
In-Reply-To: <1387078339.22351.2.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On Sun, Dec 15, 2013 at 11:32:19AM +0800, Axel Lin wrote:
[...]
s/pwm/PWM/ in the subject, please.
[...]
> @@ -64,7 +60,7 @@ static int ab8500_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
>
> ret = abx500_mask_and_set_register_interruptible(chip->dev,
> AB8500_MISC, AB8500_PWM_OUT_CTRL7_REG,
> - 1 << (chip->base - 1), ENABLE_PWM);
> + 1 << (chip->base - 1), 1 << (chip->base - 1));
I think we really need to find some other way to do this. At some point
I imagine board will move to DT, at which point we can no longer rely on
chip->base being set to a meaningful value.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-17 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 3:32 [PATCH] pwm: ab8500: Fix wrong value shift for disable/enable pwm Axel Lin
2013-12-16 8:25 ` Axel Lin
2013-12-17 9:30 ` Thierry Reding [this message]
2014-04-09 13:18 ` Axel Lin
2013-12-20 17:10 ` Linus Walleij
2014-01-06 8:55 ` Alexandre BOURDIOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217093049.GA13823@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=arun.murthy@stericsson.com \
--cc=axel.lin@ingics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.