From: Ingo Molnar <mingo@kernel.org>
To: Will Deacon <will.deacon@arm.com>
Cc: "jean.pihet@linaro.org" <jean.pihet@linaro.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
Arnaldo <acme@ghostprotocols.net>,
"patches@linaro.org" <patches@linaro.org>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH 0/3] ARM64: add perf support
Date: Tue, 17 Dec 2013 12:08:56 +0100 [thread overview]
Message-ID: <20131217110856.GA27791@gmail.com> (raw)
In-Reply-To: <20131217110154.GA7602@mudshark.cambridge.arm.com>
* Will Deacon <will.deacon@arm.com> wrote:
> On Tue, Dec 17, 2013 at 10:45:34AM +0000, Ingo Molnar wrote:
> > * jean.pihet@linaro.org <jean.pihet@linaro.org> wrote:
> > > From: Jean Pihet <jean.pihet@linaro.org>
> > >
> > > Add perf support for the AARCH64 architecture. This includes the
> > > support for:
> > > - AARCH64 perf registers definition and hooks,
> > > - compat mode registers use, i.e. profiling a 32-bit binary on
> > > a 64-bit system,
> > > - unwinding using the dwarf information from the .debug_frame
> > > section of the ELF binary; only in 64-bit mode,
> > > - unwinding using the frame pointer information; in 64-bit and
> > > compat modes.
> > >
> > > ToDo:
> > > - add support for unwinding using the dwarf information in compat
> > > mode. This requires some changes to the libunwind code.
> > >
> > > Tested on ARMv7 and ARMv8 platforms. The compat mode has been tested
> > > on ARMv8 using statically built 32-bit binaries.
> > >
> > >
> > > Jean Pihet (3):
> > > ARM64: perf: add support for perf registers API
> > > ARM64: perf: wire up perf_regs and unwind support
> > > ARM64: perf: add support for frame pointer unwinding in compat mode
> > >
> > > arch/arm64/Kconfig | 2 +
> > > arch/arm64/include/asm/ptrace.h | 1 +
> > > arch/arm64/include/uapi/asm/Kbuild | 1 +
> > > arch/arm64/include/uapi/asm/perf_regs.h | 40 ++++++++++++++
> > > arch/arm64/kernel/Makefile | 1 +
> > > arch/arm64/kernel/perf_event.c | 75 +++++++++++++++++++++++---
> > > arch/arm64/kernel/perf_regs.c | 46 ++++++++++++++++
> > > tools/perf/arch/arm64/Makefile | 7 +++
> > > tools/perf/arch/arm64/include/perf_regs.h | 88 +++++++++++++++++++++++++++++++
> > > tools/perf/arch/arm64/util/dwarf-regs.c | 81 ++++++++++++++++++++++++++++
> > > tools/perf/arch/arm64/util/unwind.c | 82 ++++++++++++++++++++++++++++
> > > tools/perf/config/Makefile | 8 ++-
> > > 12 files changed, 423 insertions(+), 9 deletions(-)
> > > create mode 100644 arch/arm64/include/uapi/asm/perf_regs.h
> > > create mode 100644 arch/arm64/kernel/perf_regs.c
> > > create mode 100644 tools/perf/arch/arm64/Makefile
> > > create mode 100644 tools/perf/arch/arm64/include/perf_regs.h
> > > create mode 100644 tools/perf/arch/arm64/util/dwarf-regs.c
> > > create mode 100644 tools/perf/arch/arm64/util/unwind.c
> >
> > Arnaldo, AFAICS the main merging complexity will probably be on
> > the perf tooling side, so if you are happy with these bits, mind
> > picking them up into your tree?
>
> Hold your horses! I've got a few review comments on the series...
Sure :-)
Thanks,
Ingo
next prev parent reply other threads:[~2013-12-17 11:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 16:49 [PATCH 0/3] ARM64: add perf support jean.pihet
2013-12-17 10:45 ` Ingo Molnar
2013-12-17 11:01 ` Will Deacon
2013-12-17 11:08 ` Ingo Molnar [this message]
2013-12-30 16:28 ` Jean Pihet
-- strict thread matches above, loose matches on Subject: below --
2013-12-16 16:54 Jean Pihet
2013-12-16 17:32 ` Will Deacon
2013-12-16 17:42 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217110856.GA27791@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=acme@infradead.org \
--cc=jean.pihet@linaro.org \
--cc=jolsa@redhat.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.