From: Steffen Klassert <steffen.klassert@secunet.com>
To: Fan Du <fan.du@windriver.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] xfrm: Namespacify xfrm_policy_sk_bundles
Date: Tue, 17 Dec 2013 12:39:50 +0100 [thread overview]
Message-ID: <20131217113950.GL31491@secunet.com> (raw)
In-Reply-To: <52AFACCA.20107@windriver.com>
On Tue, Dec 17, 2013 at 09:45:46AM +0800, Fan Du wrote:
>
>
> On 2013年12月16日 20:23, Steffen Klassert wrote:
> >On Mon, Dec 16, 2013 at 06:26:08PM +0800, Fan Du wrote:
> >>
> >>And also since xfrm_policy_sk_bundles is only used in xfrm_lookup and
> >>__xfrm_garbage_collect, both in process context, no reason we should turn
> >>BH off.
> >
> >Are you sure about that?
> >
> >__xfrm_garbage_collect() is called via dst_alloc() which can be called
> >from softirq and process context.
>
> Thanks for pointing this out, you are correct! :)
>
> IMO, xchg can still cover those two cases:
> 1. xfrm_lookup(Process context) vs __xfrm_garbage_collect(softirq context)
> 2. xfrm_lookup(Process context) vs __xfrm_garbage_collect(Process context when SPD change or dev down)
>
> I will fix commit message properly on v2 if you are ok with above description.
Yes, please fix and resend.
prev parent reply other threads:[~2013-12-17 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 10:26 [PATCH net-next] xfrm: Namespacify xfrm_policy_sk_bundles Fan Du
2013-12-16 12:23 ` Steffen Klassert
2013-12-17 1:45 ` Fan Du
2013-12-17 11:39 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217113950.GL31491@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.