From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] arm64: drop redundant macros from read_cpuid()
Date: Tue, 17 Dec 2013 12:04:31 +0000 [thread overview]
Message-ID: <20131217120431.GE32118@arm.com> (raw)
In-Reply-To: <1387227878-30438-2-git-send-email-ard.biesheuvel@linaro.org>
On Mon, Dec 16, 2013 at 09:04:35PM +0000, Ard Biesheuvel wrote:
> #define read_cpuid(reg) ({ \
> u64 __val; \
> - asm("mrs %0, " reg : "=r" (__val)); \
> + asm("mrs %0, " #reg : "=r" (__val)); \
> __val; \
> })
>
> @@ -54,12 +44,12 @@
> */
> static inline u32 __attribute_const__ read_cpuid_id(void)
> {
> - return read_cpuid(ID_MIDR_EL1);
> + return read_cpuid(MIDR_EL1);
> }
It makes sense. Just nitpick, could you please use lowercase register
names for consistency?
Thanks.
--
Catalin
next prev parent reply other threads:[~2013-12-17 12:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 21:04 [PATCH 0/4] arm64: advertise availability of CRC and crypto instructions Ard Biesheuvel
2013-12-16 21:04 ` [PATCH 1/4] arm64: drop redundant macros from read_cpuid() Ard Biesheuvel
2013-12-17 12:04 ` Catalin Marinas [this message]
2013-12-17 12:10 ` Will Deacon
2013-12-17 12:12 ` Catalin Marinas
2013-12-16 21:04 ` [PATCH 2/4] arm64: Add hwcaps for crypto and CRC32 extensions Ard Biesheuvel
2013-12-17 12:08 ` Catalin Marinas
2013-12-17 12:11 ` Catalin Marinas
2013-12-16 21:04 ` [PATCH 3/4] ARM: allocate hwcaps bits for v8 crypto extensions Ard Biesheuvel
2013-12-16 21:04 ` [PATCH 4/4] arm64: add 32-bit compat hwcaps " Ard Biesheuvel
2013-12-17 12:25 ` [PATCH 0/4] arm64: advertise availability of CRC and crypto instructions Catalin Marinas
2013-12-18 9:50 ` Ard Biesheuvel
2013-12-18 10:03 ` Russell King - ARM Linux
2013-12-18 10:25 ` Ard Biesheuvel
2013-12-18 10:55 ` Russell King - ARM Linux
2013-12-18 11:15 ` Ard Biesheuvel
2013-12-18 11:27 ` Catalin Marinas
2013-12-18 11:34 ` Catalin Marinas
2013-12-18 11:42 ` Russell King - ARM Linux
2013-12-18 11:59 ` Ard Biesheuvel
2013-12-18 12:03 ` Catalin Marinas
2013-12-18 14:27 ` Christopher Covington
2013-12-18 16:13 ` Ard Biesheuvel
2013-12-18 17:29 ` Catalin Marinas
2013-12-18 18:50 ` Ard Biesheuvel
2013-12-19 11:11 ` Catalin Marinas
2013-12-18 19:57 ` Nicolas Pitre
2013-12-18 20:26 ` Ard Biesheuvel
2013-12-18 21:18 ` Nicolas Pitre
2013-12-18 21:57 ` Ard Biesheuvel
2013-12-19 6:48 ` Siarhei Siamashka
2013-12-19 11:48 ` Catalin Marinas
2013-12-20 6:29 ` Siarhei Siamashka
2013-12-20 11:27 ` Catalin Marinas
2013-12-19 17:33 ` Ard Biesheuvel
2013-12-20 1:35 ` Siarhei Siamashka
2013-12-19 18:07 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217120431.GE32118@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.