From: Matt Fleming <matt@console-pimps.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Linux EFI <linux-efi@vger.kernel.org>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>,
Matthew Garrett <mjg59@srcf.ucam.org>,
"H. Peter Anvin" <hpa@zytor.com>, Dave Young <dyoung@redhat.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Vivek Goyal <vgoyal@redhat.com>, Toshi Kani <toshi.kani@hp.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH 3/3] efi: Make efi virtual runtime map passing more robust
Date: Tue, 17 Dec 2013 13:51:56 +0000 [thread overview]
Message-ID: <20131217135156.GC3145@console-pimps.org> (raw)
In-Reply-To: <20131217134006.GC30592@pd.tnic>
On Tue, 17 Dec, at 02:40:06PM, Borislav Petkov wrote:
> On Tue, Dec 17, 2013 at 12:10:24PM +0000, Matt Fleming wrote:
> > You sunk my i386 battleship,
> >
> > /home/build/git/efi/arch/x86/platform/efi/efi.c:824:24: error: ‘struct real_mode_header’ has no member named ‘trampoline_pgd’
> > make[4]: *** [arch/x86/platform/efi/efi.o] Error 1
> > make[3]: *** [arch/x86/platform/efi] Error 2
>
> Right, this is a recurring issue with the trampoline_pgd. What do you
> prefer: an #ifdef CONFIG_X86_64 or a separate function in efi_$(BITS).c?
Couldn't we do the mapping in efi_setup_page_tables() if we pass
__pa(new_memmap) and 1 << new_memmap_shift as arguments?
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-12-17 13:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 23:36 [PATCH 0/3] EFI memmap fix Borislav Petkov
2013-12-16 23:36 ` Borislav Petkov
2013-12-16 23:36 ` [PATCH 1/3] x86, ptdump: Add the functionality to dump an arbitrary pagetable Borislav Petkov
[not found] ` <1387236997-26975-1-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2013-12-16 23:36 ` [PATCH 2/3] efi: Dump the EFI page table Borislav Petkov
2013-12-16 23:36 ` Borislav Petkov
2013-12-17 1:11 ` [PATCH 0/3] EFI memmap fix Toshi Kani
2013-12-17 1:11 ` Toshi Kani
2013-12-16 23:36 ` [PATCH 3/3] efi: Make efi virtual runtime map passing more robust Borislav Petkov
[not found] ` <1387236997-26975-4-git-send-email-bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
2013-12-17 11:23 ` Borislav Petkov
2013-12-17 11:23 ` Borislav Petkov
2013-12-17 12:10 ` Matt Fleming
2013-12-17 12:10 ` Matt Fleming
2013-12-17 13:40 ` Borislav Petkov
2013-12-17 13:51 ` Matt Fleming [this message]
[not found] ` <20131217135156.GC3145-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-12-17 14:28 ` Borislav Petkov
2013-12-17 14:28 ` Borislav Petkov
2013-12-18 9:07 ` Dave Young
[not found] ` <20131218090757.GA15594-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2013-12-18 11:42 ` Borislav Petkov
2013-12-18 11:42 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217135156.GC3145@console-pimps.org \
--to=matt@console-pimps.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=toshi.kani@hp.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.