From: Ingo Molnar <mingo@kernel.org>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
eranian@google.com, andi@firstfloor.org,
Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH 04/15] perf, x86: Use context switch callback to flush LBR stack
Date: Tue, 17 Dec 2013 17:10:22 +0100 [thread overview]
Message-ID: <20131217161022.GA13205@gmail.com> (raw)
In-Reply-To: <1386745860-21143-5-git-send-email-zheng.z.yan@intel.com>
* Yan, Zheng <zheng.z.yan@intel.com> wrote:
> From: "Yan, Zheng" <zheng.z.yan@intel.com>
>
> Enable pmu context switch callback if LBR is used. Use the callback
> to flush LBR stack when process is scheduled in.
>
> Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
I see several fundamental problems with your series:
1)
Minimal changelogs like the ones in this series are completely
unacceptable! You seem to be copying the changelog style of Andi
Kleen: written to inform as little as possible.
Don't do that if you want your patches to get anywhere, instead adapt
the akpm style:
"Please update the changelog to describe the current behavior.
Please also describe why you think that behavior should be changed.
ie: what's the reason for this patch.
"
2)
Also, there are frequent typos.
3)
Plus you didn't Cc: other perf maintainers like myself or Arnaldo.
4)
How can users actually make use of the changes you are doing? Cite
actual perf analysis usecases in the 0/15 description and describe how
your patches improve/enable all that.
Please fix all those problems and resend.
Thanks,
Ingo
next prev parent reply other threads:[~2013-12-17 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 7:10 [PATCH 00/15] perf, x86: Haswell LBR call stack support Yan, Zheng
2013-12-11 7:10 ` [PATCH 01/15] perf, x86: Reduce lbr_sel_map size Yan, Zheng
2013-12-11 7:10 ` [PATCH 02/15] perf, x86: Basic Haswell LBR call stack support Yan, Zheng
2013-12-11 7:10 ` [PATCH 03/15] perf, core: Introduce pmu context switch callback Yan, Zheng
2013-12-11 7:10 ` [PATCH 04/15] perf, x86: Use context switch callback to flush LBR stack Yan, Zheng
2013-12-17 16:10 ` Ingo Molnar [this message]
2013-12-11 7:10 ` [PATCH 05/15] perf, core: Optimize context switch callback invoking Yan, Zheng
2013-12-11 7:10 ` [PATCH 06/15] perf, core: PMU specific data for perf task context Yan, Zheng
2013-12-11 7:10 ` [PATCH 07/15] perf, core: Always swtich pmu specific data during context switch Yan, Zheng
2013-12-11 7:10 ` [PATCH 08/15] perf, x86: Allocate memory for saving LBR stack Yan, Zheng
2013-12-11 7:10 ` [PATCH 09/15] perf: Track system-wide LBR users and LBR callstack users Yan, Zheng
2013-12-11 7:10 ` [PATCH 10/15] perf, x86: Save/resotre LBR stack during context switch Yan, Zheng
2013-12-11 7:10 ` [PATCH 11/15] perf, core: Simplify need branch stack check Yan, Zheng
2013-12-11 7:10 ` [PATCH 12/15] perf, core: Pass perf_sample_data to perf_callchain() Yan, Zheng
2013-12-11 7:10 ` [PATCH 13/15] perf, x86: Use LBR call stack to get user callchain Yan, Zheng
2013-12-11 7:10 ` [PATCH 14/15] perf, x86: Enable LBR callstack when recording callchain Yan, Zheng
2013-12-11 7:11 ` [PATCH 15/15] perf, x86: Discard zero length call entries in LBR call stack Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217161022.GA13205@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.