From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754898Ab3LQQfh (ORCPT ); Tue, 17 Dec 2013 11:35:37 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:51553 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752800Ab3LQQfe convert rfc822-to-8bit (ORCPT ); Tue, 17 Dec 2013 11:35:34 -0500 X-Originating-IP: 50.43.14.201 Date: Tue, 17 Dec 2013 08:35:25 -0800 From: Josh Triplett To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Len Brown , sfi-devel@simplefirmware.org Subject: Re: [PATCH 2/2] drivers: sfi: Mark functions as static in sfi_core.c Message-ID: <20131217163525.GD737@leaf> References: <78c9d53e2266bfdf06bf1d545cb2cf7fb5e7226c.1387283325.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <78c9d53e2266bfdf06bf1d545cb2cf7fb5e7226c.1387283325.git.rashika.kheria@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 17, 2013 at 06:04:50PM +0530, Rashika Kheria wrote: > Mark functions sfi_map_table() and sfi_unmap_table() as static in > sfi_core.c because they are not used outside this file. > > This eliminates following warning in sfi_core.c: > drivers/sfi/sfi_core.c:164:26: warning: no previous prototype for ‘sfi_map_table’ [-Wmissing-prototypes] > drivers/sfi/sfi_core.c:192:6: warning: no previous prototype for ‘sfi_unmap_table’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett > drivers/sfi/sfi_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c > index 1e824fb..296db7a 100644 > --- a/drivers/sfi/sfi_core.c > +++ b/drivers/sfi/sfi_core.c > @@ -161,7 +161,7 @@ static int sfi_verify_table(struct sfi_table_header *table) > * Check for common case that we can re-use mapping to SYST, > * which requires syst_pa, syst_va to be initialized. > */ > -struct sfi_table_header *sfi_map_table(u64 pa) > +static struct sfi_table_header *sfi_map_table(u64 pa) > { > struct sfi_table_header *th; > u32 length; > @@ -189,7 +189,7 @@ struct sfi_table_header *sfi_map_table(u64 pa) > * Undoes effect of sfi_map_table() by unmapping table > * if it did not completely fit on same page as SYST. > */ > -void sfi_unmap_table(struct sfi_table_header *th) > +static void sfi_unmap_table(struct sfi_table_header *th) > { > if (!TABLE_ON_PAGE(syst_va, th, th->len)) > sfi_unmap_memory(th, TABLE_ON_PAGE(th, th, th->len) ? > -- > 1.7.9.5 >