All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers: ide: Include appropriate header file in ide-pio-blacklist.c
Date: Tue, 17 Dec 2013 08:37:51 -0800	[thread overview]
Message-ID: <20131217163751.GC1062@leaf> (raw)
In-Reply-To: <2ec755ae03ae9f912f40a12a241f997909f380a1.1387278225.git.rashika.kheria@gmail.com>

On Tue, Dec 17, 2013 at 04:41:11PM +0530, Rashika Kheria wrote:
> Include appropriate header file include/linux/ide.h in file
> ide-pio-blacklist.c because function ide_scan_pio_blacklist() has it's
> prototype declaration in include/linux/ide.h.
> 
> This eliminates the following warning in ide-pio-blacklist.c:
> drivers/ide/ide-pio-blacklist.c:85:5: warning: no previous prototype for ‘ide_scan_pio_blacklist’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/ide/ide-pio-blacklist.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ide/ide-pio-blacklist.c b/drivers/ide/ide-pio-blacklist.c
> index a8c2c8f8..40e683a 100644
> --- a/drivers/ide/ide-pio-blacklist.c
> +++ b/drivers/ide/ide-pio-blacklist.c
> @@ -7,6 +7,7 @@
>   */
>  
>  #include <linux/string.h>
> +#include <linux/ide.h>
>  
>  static struct ide_pio_info {
>  	const char	*name;
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2013-12-17 16:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 11:08 [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd_verbose.c Rashika Kheria
2013-12-17 11:11 ` [PATCH 2/2] drivers: ide: Include appropriate header file in ide-pio-blacklist.c Rashika Kheria
2013-12-17 16:37   ` Josh Triplett [this message]
2014-01-29  7:37   ` David Miller
2014-01-29  7:37     ` David Miller
2013-12-17 11:19 ` [PATCH 1/2] drivers: ide: Include appropriate header file in ide-cd_verbose.c Borislav Petkov
2013-12-17 16:44   ` Josh Triplett
2013-12-17 17:54     ` Borislav Petkov
2013-12-17 19:42       ` Sergei Shtylyov
2013-12-17 19:06         ` Borislav Petkov
2013-12-18 13:23           ` Bartlomiej Zolnierkiewicz
2013-12-18 13:33             ` Borislav Petkov
2013-12-18 18:35           ` Sergei Shtylyov
2013-12-17 16:37 ` Josh Triplett
2013-12-17 18:11 ` Sergei Shtylyov
2014-01-29  7:36 ` David Miller
2014-01-29  7:36   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217163751.GC1062@leaf \
    --to=josh@joshtriplett.org \
    --cc=davem@davemloft.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rashika.kheria@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.