From: Tyler Hicks <tyhicks@canonical.com>
To: David Howells <dhowells@redhat.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
ecryptfs@vger.kernel.org
Subject: Re: [PATCH 5/9] Use %pd in eCryptFS
Date: Tue, 17 Dec 2013 09:45:19 -0800 [thread overview]
Message-ID: <20131217174519.GA5177@boyd> (raw)
In-Reply-To: <20131210152648.4916.63963.stgit@warthog.procyon.org.uk>
[-- Attachment #1: Type: text/plain, Size: 2969 bytes --]
On 2013-12-10 15:26:48, David Howells wrote:
> Use the new %pd printk() specifier in eCryptFS to replace passing of dentry
> name or dentry name and name length * 2 with just passing the dentry.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Tyler Hicks <tyhicks@canonical.com>
Acked-by: Tyler Hicks <tyhicks@canonical.com>
Thanks for the patch! It looks like you're asking the individual
filesystem maintainers to carry the patch so I'll throw it into my -next
branch.
Tyler
> cc: ecryptfs@vger.kernel.org
> ---
>
> fs/ecryptfs/file.c | 4 ++--
> fs/ecryptfs/inode.c | 12 ++++++------
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c
> index b1eaa7a1f82c..c705360e2b16 100644
> --- a/fs/ecryptfs/file.c
> +++ b/fs/ecryptfs/file.c
> @@ -230,8 +230,8 @@ static int ecryptfs_open(struct inode *inode, struct file *file)
> if (rc) {
> printk(KERN_ERR "%s: Error attempting to initialize "
> "the lower file for the dentry with name "
> - "[%s]; rc = [%d]\n", __func__,
> - ecryptfs_dentry->d_name.name, rc);
> + "[%pd]; rc = [%d]\n", __func__,
> + ecryptfs_dentry, rc);
> goto out_free;
> }
> if ((ecryptfs_inode_to_private(inode)->lower_file->f_flags & O_ACCMODE)
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
> index c36c44824471..87ad33e091e9 100644
> --- a/fs/ecryptfs/inode.c
> +++ b/fs/ecryptfs/inode.c
> @@ -250,8 +250,8 @@ int ecryptfs_initialize_file(struct dentry *ecryptfs_dentry,
> if (rc) {
> printk(KERN_ERR "%s: Error attempting to initialize "
> "the lower file for the dentry with name "
> - "[%s]; rc = [%d]\n", __func__,
> - ecryptfs_dentry->d_name.name, rc);
> + "[%pd]; rc = [%d]\n", __func__,
> + ecryptfs_dentry, rc);
> goto out;
> }
> rc = ecryptfs_write_metadata(ecryptfs_dentry, ecryptfs_inode);
> @@ -313,8 +313,8 @@ static int ecryptfs_i_size_read(struct dentry *dentry, struct inode *inode)
> if (rc) {
> printk(KERN_ERR "%s: Error attempting to initialize "
> "the lower file for the dentry with name "
> - "[%s]; rc = [%d]\n", __func__,
> - dentry->d_name.name, rc);
> + "[%pd]; rc = [%d]\n", __func__,
> + dentry, rc);
> return rc;
> }
>
> @@ -418,8 +418,8 @@ static struct dentry *ecryptfs_lookup(struct inode *ecryptfs_dir_inode,
> if (IS_ERR(lower_dentry)) {
> rc = PTR_ERR(lower_dentry);
> ecryptfs_printk(KERN_DEBUG, "%s: lookup_one_len() returned "
> - "[%d] on lower_dentry = [%s]\n", __func__, rc,
> - ecryptfs_dentry->d_name.name);
> + "[%d] on lower_dentry = [%pd]\n", __func__, rc,
> + ecryptfs_dentry);
> goto out;
> }
> if (lower_dentry->d_inode)
>
> --
> To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-17 17:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 15:26 [PATCH 0/9] Patches promoting the use of %pd in printk David Howells
2013-12-10 15:26 ` [PATCH 1/9] Use %pd in AFS David Howells
2013-12-10 15:26 ` [PATCH 2/9] Use %pd in AutoFS David Howells
2013-12-11 2:08 ` Ian Kent
2013-12-11 12:09 ` David Howells
2013-12-12 2:43 ` Ian Kent
2013-12-10 15:26 ` [PATCH 3/9] Use %pd in CacheFiles David Howells
[not found] ` <20131210152612.4916.80435.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2013-12-10 15:26 ` [PATCH 4/9] Use %pd in CIFS David Howells
2013-12-10 15:26 ` [PATCH 5/9] Use %pd in eCryptFS David Howells
2013-12-17 17:45 ` Tyler Hicks [this message]
2013-12-10 15:26 ` [PATCH 6/9] Use %pd in Ext4 David Howells
2013-12-10 15:58 ` Theodore Ts'o
2013-12-11 12:10 ` David Howells
2014-01-06 14:43 ` Theodore Ts'o
2013-12-10 15:27 ` [PATCH 7/9] Use %pd in NFSD David Howells
2013-12-10 15:27 ` [PATCH 8/9] Use %pd in ConfigFS David Howells
2013-12-10 15:27 ` [PATCH 9/9] Use %pd in general VFS code David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217174519.GA5177@boyd \
--to=tyhicks@canonical.com \
--cc=dhowells@redhat.com \
--cc=ecryptfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.