All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-pci@vger.kernel.org, ddutile@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support
Date: Tue, 17 Dec 2013 11:03:22 -0700	[thread overview]
Message-ID: <20131217180322.GA12482@google.com> (raw)
In-Reply-To: <20131210184845.26294.81385.stgit@bling.home>

On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote:
>...
> +	pci_read_config_dword(dev->bus->self, pos2 + PCI_VC_PORT_REG1, &reg1);
> +	evcc = reg1 & PCI_VC_REG1_EVCC;

I think PCI_VC_PORT_REG1 and PCI_VC_PORT_REG2 are mis-named and should be
changed to CAP1 and CAP2 or similar.  Almost everything here is a
"register."

Bjorn

  parent reply	other threads:[~2013-12-17 18:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 18:48 [PATCH 0/3] pci: virtual channel save/restore support Alex Williamson
2013-12-10 18:48 ` [PATCH 1/3] pci: Generalize wait loop Alex Williamson
2013-12-10 18:48 ` [PATCH 2/3] pci: Add support for save/restore of extended capabilities Alex Williamson
2013-12-10 18:48 ` [PATCH 3/3] pci: Add Virtual Channel to save/restore support Alex Williamson
2013-12-17  0:48   ` Bjorn Helgaas
2013-12-17 22:12     ` Alex Williamson
2013-12-17 22:24       ` Bjorn Helgaas
2013-12-17 22:33         ` Alex Williamson
2013-12-17 22:26       ` Bjorn Helgaas
2013-12-17 18:03   ` Bjorn Helgaas [this message]
2013-12-17 20:28     ` Alex Williamson
2013-12-17 21:57       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217180322.GA12482@google.com \
    --to=bhelgaas@google.com \
    --cc=alex.williamson@redhat.com \
    --cc=ddutile@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.