Re: [PATCH v2 RESEND 2/2] ASOC: tegra: fix AC97 clock handling

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1173 bytes --]

On Tue, Dec 17, 2013 at 03:49:53PM +0100, Lucas Stach wrote:
> Am Dienstag, den 17.12.2013, 14:00 +0000 schrieb Mark Brown:

> > I don't understand this commit message at all I'm afraid.  What does it
> > mean to "be in line with the devicetree" and what is the purpose of this
> > change?

> Clocks were added to the DT after the Tegra AC97 driver was initially
> pushed upstream and the layout changed a bit in the process. Stephen
> Warren convinced me that it's the right thing to let the Audio PLL be
> controlled by the ASoC machine driver, rather than the AC97 host
> controller driver.

> So currently the host controller driver asks for clocks that aren't
> there in the DT. This change corrects the clock handling so that the
> host controller driver only ask for it's own clock, but the Audio PLL
> handling is pushed into the machine driver.

Are we sure this is the best thing to do here?  There is standard
clocking behaviour specified in AC'97 so if the machine driver clocking
control includes that it's not clear that we want to vary it.  In any
case a clearer changelog explaining that the driver never worked due to
these clocking changes would be good.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]