* [PATCH] ASoC: wm8904: fix DSP mode B configuration
@ 2013-12-18 3:26 ` Bo Shen
0 siblings, 0 replies; 7+ messages in thread
From: Bo Shen @ 2013-12-18 3:26 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, patches, linux-sound, Bo Shen, ckeepax,
linux-arm-kernel
When wm8904 work in DSP mode B, we still need to configure it to
work in DSP mode. Or else, it will work in Right Justified mode.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
sound/soc/codecs/wm8904.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index 3938fb1..53bbfac 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -1444,7 +1444,7 @@ static int wm8904_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
case SND_SOC_DAIFMT_DSP_B:
- aif1 |= WM8904_AIF_LRCLK_INV;
+ aif1 |= 0x3 | WM8904_AIF_LRCLK_INV;
case SND_SOC_DAIFMT_DSP_A:
aif1 |= 0x3;
break;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] ASoC: wm8904: fix DSP mode B configuration
@ 2013-12-18 3:26 ` Bo Shen
0 siblings, 0 replies; 7+ messages in thread
From: Bo Shen @ 2013-12-18 3:26 UTC (permalink / raw)
To: linux-arm-kernel
When wm8904 work in DSP mode B, we still need to configure it to
work in DSP mode. Or else, it will work in Right Justified mode.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
sound/soc/codecs/wm8904.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index 3938fb1..53bbfac 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -1444,7 +1444,7 @@ static int wm8904_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
case SND_SOC_DAIFMT_DSP_B:
- aif1 |= WM8904_AIF_LRCLK_INV;
+ aif1 |= 0x3 | WM8904_AIF_LRCLK_INV;
case SND_SOC_DAIFMT_DSP_A:
aif1 |= 0x3;
break;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] ASoC: wm8904: fix DSP mode B configuration
@ 2013-12-18 3:26 ` Bo Shen
0 siblings, 0 replies; 7+ messages in thread
From: Bo Shen @ 2013-12-18 3:26 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, patches, linux-sound, Bo Shen, ckeepax,
linux-arm-kernel
When wm8904 work in DSP mode B, we still need to configure it to
work in DSP mode. Or else, it will work in Right Justified mode.
Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
sound/soc/codecs/wm8904.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
index 3938fb1..53bbfac 100644
--- a/sound/soc/codecs/wm8904.c
+++ b/sound/soc/codecs/wm8904.c
@@ -1444,7 +1444,7 @@ static int wm8904_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
case SND_SOC_DAIFMT_DSP_B:
- aif1 |= WM8904_AIF_LRCLK_INV;
+ aif1 |= 0x3 | WM8904_AIF_LRCLK_INV;
case SND_SOC_DAIFMT_DSP_A:
aif1 |= 0x3;
break;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ASoC: wm8904: fix DSP mode B configuration
2013-12-18 3:26 ` Bo Shen
@ 2013-12-18 9:23 ` Charles Keepax
-1 siblings, 0 replies; 7+ messages in thread
From: Charles Keepax @ 2013-12-18 9:23 UTC (permalink / raw)
To: Bo Shen; +Cc: broonie, patches, linux-sound, alsa-devel, linux-arm-kernel
On Wed, Dec 18, 2013 at 11:26:23AM +0800, Bo Shen wrote:
> When wm8904 work in DSP mode B, we still need to configure it to
> work in DSP mode. Or else, it will work in Right Justified mode.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ASoC: wm8904: fix DSP mode B configuration
2013-12-18 3:26 ` Bo Shen
@ 2013-12-18 11:31 ` Mark Brown
-1 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2013-12-18 11:31 UTC (permalink / raw)
To: Bo Shen; +Cc: patches, ckeepax, linux-sound, alsa-devel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
On Wed, Dec 18, 2013 at 11:26:23AM +0800, Bo Shen wrote:
> When wm8904 work in DSP mode B, we still need to configure it to
> work in DSP mode. Or else, it will work in Right Justified mode.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-12-18 11:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-18 3:26 [PATCH] ASoC: wm8904: fix DSP mode B configuration Bo Shen
2013-12-18 3:26 ` Bo Shen
2013-12-18 3:26 ` Bo Shen
2013-12-18 9:23 ` Charles Keepax
2013-12-18 9:23 ` Charles Keepax
2013-12-18 11:31 ` Mark Brown
2013-12-18 11:31 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.