From: Arnd Bergmann <arnd@arndb.de>
To: Dave Young <dyoung@redhat.com>
Cc: Mark Salter <msalter@redhat.com>,
linux-kernel@vger.kernel.org,
Leif Lindholm <leif.lindholm@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/4] Create generic early_ioremap() support
Date: Wed, 18 Dec 2013 11:40:00 +0100 [thread overview]
Message-ID: <201312181140.01134.arnd@arndb.de> (raw)
In-Reply-To: <20131218091348.GB15594@dhcp-16-126.nay.redhat.com>
On Wednesday 18 December 2013, Dave Young wrote:
> >
> > I hadn't really thought about it. Putting these things in mm doesn't
> > sound unreasonable, but lib seems to have become the place for a lot
> > generic code which could also belong in mm, net, etc.
> >
>
> IMHO, move subsystem lib code to subsystem core dir looks more reasonable.
> lib should be the place for general kernel stuff.
>
> I'm not specific for and object this patch, just give my opinion about the lib/..
Traditionally, lib/ is for things that may or may not be used by other optional
code, typically drivers, which I think is a reasonable concept. There has been
some shift over the years from lib-$(CONFIG_FOO) towards obj-$(CONFIG_FOO),
so it's not always used as a actual library code in the linker sense though.
I would agree that moving mm related code such as early_ioremap into mm/ is
a good idea. For things like the compression helpers lib/ is probably
still the best place.
Arnd
next prev parent reply other threads:[~2013-12-18 10:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 2:44 [PATCH 0/4] generic early_ioremap support Mark Salter
2013-11-28 2:44 ` Mark Salter
2013-11-28 2:44 ` [PATCH 1/4] Create generic early_ioremap() support Mark Salter
2013-12-16 1:48 ` Dave Young
2013-12-17 18:45 ` Mark Salter
2013-12-18 9:13 ` Dave Young
2013-12-18 10:40 ` Arnd Bergmann [this message]
2013-11-28 2:44 ` [PATCH 2/4] x86: use generic early_ioremap Mark Salter
2013-11-28 2:44 ` [PATCH 3/4] arm: add early_ioremap support Mark Salter
2013-11-28 2:44 ` Mark Salter
2013-11-28 2:44 ` [PATCH 4/4] arm64: " Mark Salter
2013-11-28 2:44 ` Mark Salter
2013-12-05 16:28 ` Catalin Marinas
2013-12-05 16:28 ` Catalin Marinas
2013-12-06 17:20 ` Mark Salter
2013-12-06 17:20 ` Mark Salter
2013-12-16 14:42 ` Catalin Marinas
2013-12-16 14:42 ` Catalin Marinas
2013-12-17 19:15 ` Mark Salter
2013-12-17 19:15 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312181140.01134.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dyoung@redhat.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=msalter@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.