From: Greg KH <gregkh@linuxfoundation.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-kernel@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk,
arnd@arndb.de, hpa@zytor.com
Subject: Re: [PATCH v2] misc: Reserve minor for VFIO
Date: Wed, 18 Dec 2013 13:01:41 -0800 [thread overview]
Message-ID: <20131218210141.GA11267@kroah.com> (raw)
In-Reply-To: <20131218204024.30540.55302.stgit@bling.home>
On Wed, Dec 18, 2013 at 01:56:32PM -0700, Alex Williamson wrote:
> VFIO currently allocates it's own dynamic chardev range, reserving the
> first minor for the control part of the interface (/dev/vfio/vfio) and
> the remainder for VFIO groups (/dev/vfio/$GROUP). This works, but it
> doesn't support auto loading. For instance when libvirt checks for
> VFIO support it looks for /dev/vfio/vfio, which currently doesn't
> exist unless the vfio module is loaded. By converting the control
> device to a misc driver and reserving a static minor, we can enable
> auto loading.
>
> Reserving the minor is a prerequist to that conversion. Minor 196
> is unused by anything currently in the kernel.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>
> v2: Plea for ack edition
>
> As Alan suspected, there's been no response from device@lanana.org,
> so there's probably nobody monitoring it anymore. I've done due
> diligence looking at all the callers of misc_register() in linux-next
> and cannot find any conflicts with minor 196. If anyone wants to toss
> me an ack or sign-off I'll be happy to bring this in through my vfio
> tree, otherwise I'd appreciate if someone wants to take it directly.
> Thanks!
>
> Documentation/devices.txt | 1 +
> include/linux/miscdevice.h | 1 +
> 2 files changed, 2 insertions(+)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Feel free to take this through your tree.
thanks,
greg k-h
next prev parent reply other threads:[~2013-12-18 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 20:56 [PATCH v2] misc: Reserve minor for VFIO Alex Williamson
2013-12-18 21:01 ` Greg KH [this message]
2013-12-18 21:04 ` Alex Williamson
2013-12-18 22:02 ` H. Peter Anvin
2013-12-18 23:55 ` One Thousand Gnomes
2013-12-19 0:18 ` H. Peter Anvin
2013-12-20 2:38 ` Konrad Rzeszutek Wilk
2013-12-20 3:31 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218210141.GA11267@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.