From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: mackerel: Fix USBHS pinconf entry
Date: Thu, 19 Dec 2013 08:27:35 +0000 [thread overview]
Message-ID: <20131219082735.GB12239@verge.net.au> (raw)
In-Reply-To: <1387032301-6609-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Sat, Dec 14, 2013 at 03:45:01PM +0100, Laurent Pinchart wrote:
> Fix a typo in the USBHS1 pinconf entry that prevented the pull-down from
> being enabled.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/board-mackerel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Simon,
>
> The bug that this patch fixes got introduced in "ARM: shmobile: mackerel: Use
> pinconf API to configure pin pull-down". Feel free to squash the fix with the
> original patch if possible.
Thanks, Laurent.
I will queue this up as an incremental patch.
>
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 207acf0..b3ee96e 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -1406,7 +1406,7 @@ static const struct pinctrl_map mackerel_pinctrl_map[] = {
> /* USBHS1 */
> PIN_MAP_MUX_GROUP_DEFAULT("renesas_usbhs.1", "pfc-sh7372",
> "usb1_vbus", "usb1"),
> - PIN_MAP_CONFIGS_GROUP_DEFAULT("renesas_usbhs.&", "pfc-sh7372",
> + PIN_MAP_CONFIGS_GROUP_DEFAULT("renesas_usbhs.1", "pfc-sh7372",
> "usb1_vbus", pin_pulldown_conf),
> PIN_MAP_MUX_GROUP_DEFAULT("renesas_usbhs.1", "pfc-sh7372",
> "usb1_otg_id_0", "usb1"),
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-12-19 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 14:45 [PATCH] ARM: shmobile: mackerel: Fix USBHS pinconf entry Laurent Pinchart
2013-12-19 8:27 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219082735.GB12239@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.