From: Jens Axboe <axboe@kernel.dk>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Ramprasad Chinthekindi <rchinthekindi@stec-inc.com>,
Akhil Bhansali <abhansali@stec-inc.com>,
josh@joshtriplett.org
Subject: Re: [PATCH 01/13] drivers: block: Mark the functions as static in skd_main.c
Date: Thu, 19 Dec 2013 08:07:01 -0700 [thread overview]
Message-ID: <20131219150701.GD30200@kernel.dk> (raw)
In-Reply-To: <f460591345e87defe53122cf056991c7f2eefa10.1387445396.git.rashika.kheria@gmail.com>
On Thu, Dec 19 2013, Rashika Kheria wrote:
> Mark functions skd_skmsg_state_to_str() and skd_skreq_state_to_str() as
> static in skd_main.c because they are not used outside this file.
>
> This eliminates the following warnings in skd_main.c:
> drivers/block/skd_main.c:5272:13: warning: no previous prototype for ‘skd_skmsg_state_to_str’ [-Wmissing-prototypes]
> drivers/block/skd_main.c:5284:13: warning: no previous prototype for ‘skd_skreq_state_to_str’ [-Wmissing-prototypes]
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2013-12-19 15:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 9:32 [PATCH 01/13] drivers: block: Mark the functions as static in skd_main.c Rashika Kheria
2013-12-19 9:33 ` [Drbd-dev] [PATCH 02/13] drivers: block: Remove unused function drbd_bm_write_lazy() in drbd_bitmap.c Rashika Kheria
2013-12-19 9:33 ` Rashika Kheria
2013-12-19 9:34 ` [Drbd-dev] [PATCH 03/13] drivers: block: Mark function seq_printf_with_thousands_grouping() as static in drbd_proc.c Rashika Kheria
2013-12-19 9:34 ` Rashika Kheria
2013-12-19 9:36 ` [Drbd-dev] [PATCH 04/13] drivers: block: Mark the function as static in drbd_worker.c Rashika Kheria
2013-12-19 9:36 ` Rashika Kheria
2013-12-19 9:37 ` [Drbd-dev] [PATCH 05/13] drivers: block: Move prototype declaration to appropriate header file from drbd_main.c Rashika Kheria
2013-12-19 9:37 ` Rashika Kheria
2013-12-19 9:41 ` [Drbd-dev] [PATCH 06/13] drivers: block: Mark functions as static in drbd_receiver.c Rashika Kheria
2013-12-19 9:41 ` Rashika Kheria
2013-12-19 9:42 ` [Drbd-dev] [PATCH 07/13] drivers: block: Mark functions as static in drbd_req.c Rashika Kheria
2013-12-19 9:42 ` Rashika Kheria
2013-12-19 9:43 ` [Drbd-dev] [PATCH 08/13] drivers: block: Mark function as static in drbd_actlog.c Rashika Kheria
2013-12-19 9:43 ` Rashika Kheria
2013-12-19 9:45 ` [Drbd-dev] [PATCH 09/13] drivers: block: Move prototype declaration of function tl_abort_disk_io() to appropriate header file from drbd_state.c Rashika Kheria
2013-12-19 9:45 ` Rashika Kheria
2013-12-19 9:46 ` [Drbd-dev] [PATCH 10/13] drivers: block: Mark functions as static in drbd_main.c Rashika Kheria
2013-12-19 9:46 ` Rashika Kheria
2013-12-19 9:47 ` [Drbd-dev] [PATCH 11/13] drivers: block: Mark functions as static in drbd_nl.c Rashika Kheria
2013-12-19 9:47 ` Rashika Kheria
2013-12-19 9:48 ` [Drbd-dev] [PATCH 12/13] drivers: block: Mark function as static in drbd_state.c Rashika Kheria
2013-12-19 9:48 ` Rashika Kheria
2014-01-31 9:35 ` [Drbd-dev] " Philipp Reisner
2013-12-19 9:52 ` [PATCH 13/13] drivers: block: Remove unused function in genl_magic_func.h Rashika Kheria
2013-12-19 9:59 ` Josh Triplett
2013-12-19 15:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219150701.GD30200@kernel.dk \
--to=axboe@kernel.dk \
--cc=abhansali@stec-inc.com \
--cc=b.zolnierkie@samsung.com \
--cc=josh@joshtriplett.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=rchinthekindi@stec-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.