From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755044Ab3LSPvk (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Dec 2013 10:51:40 -0500
Received: from merlin.infradead.org ([205.233.59.134]:56310 "EHLO
	merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754491Ab3LSPv1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Dec 2013 10:51:27 -0500
Date: Thu, 19 Dec 2013 16:51:21 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Dave Jones <davej@redhat.com>
Subject: Re: lockdep: BUG: MAX_LOCKDEP_ENTRIES too low!
Message-ID: <20131219155121.GL16438@laptop.programming.kicks-ass.net>
References: <52B289F4.7060205@oracle.com>
 <20131219103401.GE30183@twins.programming.kicks-ass.net>
 <52B2FC66.9010309@oracle.com>
 <20131219152002.GK16438@laptop.programming.kicks-ass.net>
 <52B3134D.2010203@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52B3134D.2010203@oracle.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 19, 2013 at 10:39:57AM -0500, Sasha Levin wrote:
> That discusses lockdep classes, which is actually fine in my case. I ran out of
> MAX_LOCKDEP_ENTRIES, which isn't mentioned anywhere in Documentation/ .

Yeah, it suffers from the same problem though. Lockdep has static
resource allocation and never frees them.

The lock classes are the smallest pool and usually run out first, but
the same could happen for the entries, after all, the more classes we
have the more class connections can happen.

Anyway, barring a leak and silly class mistakes like mentioned in the
document there's nothing we can do except raise the number.