From: Greg KH <gregkh@linuxfoundation.org>
To: Denis Turischev <denis.turischev@compulab.co.il>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: xhci: Switch Intel Lynx Point ports to EHCI on shutdown
Date: Thu, 19 Dec 2013 08:38:21 -0800 [thread overview]
Message-ID: <20131219163821.GA27409@kroah.com> (raw)
In-Reply-To: <52B31EDA.60908@compulab.co.il>
On Thu, Dec 19, 2013 at 06:29:14PM +0200, Denis Turischev wrote:
> The same issue like with Panther Point chipsets. If the USB ports are
> switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
> which will wake the system. Some BIOS have work around for this, but not all.
>
> The bug can be avoided if the USB ports are switched back to EHCI on
> shutdown.
>
> Signed-off-by: Denis Turischev <denis@compulab.co.il>
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> --- a/drivers/usb/host/xhci-pci.c 2013-12-19 11:36:12.049589400 +0200
> +++ b/drivers/usb/host/xhci-pci.c 2013-12-19 11:37:27.261590385 +0200
> @@ -91,8 +91,9 @@
> xhci->quirks |= XHCI_LPM_SUPPORT;
> xhci->quirks |= XHCI_INTEL_HOST;
> }
> - if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> - pdev->device == PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI) {
> + if (pdev->vendor == PCI_VENDOR_ID_INTEL && (
> + (pdev->device == PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI) ||
> + (pdev->device == PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI))) {
> xhci->quirks |= XHCI_EP_LIMIT_QUIRK;
> xhci->limit_active_eps = 64;
> xhci->quirks |= XHCI_SW_BW_CHECKING;
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> --- a/include/linux/pci_ids.h 2013-12-19 11:36:11.945589398 +0200
> +++ b/include/linux/pci_ids.h 2013-12-19 11:35:57.817589213 +0200
> @@ -2576,6 +2576,7 @@
> #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX 0x1c5f
> #define PCI_DEVICE_ID_INTEL_PATSBURG_LPC_0 0x1d40
> #define PCI_DEVICE_ID_INTEL_PATSBURG_LPC_1 0x1d41
> +#define PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI 0x9c31
Please read the top of this file for why to not add new device ids to
it.
And if you really need to do so, please do it in sorted order:
> #define PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI 0x1e31
> #define PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MIN 0x1e40
> #define PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX 0x1e5f
Which you didn't do :(
greg k-h
next prev parent reply other threads:[~2013-12-19 16:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 16:29 xhci: Switch Intel Lynx Point ports to EHCI on shutdown Denis Turischev
2013-12-19 16:38 ` Greg KH [this message]
2013-12-19 17:07 ` [PATCH v1] " Denis Turischev
2013-12-19 18:21 ` Sarah Sharp
2013-12-20 10:41 ` Denis Turischev
2013-12-20 23:45 ` Sarah Sharp
2013-12-21 16:45 ` Holger Freyther
2013-12-22 7:47 ` Denis Turischev
2014-01-03 0:03 ` Sarah Sharp
2014-01-03 3:40 ` littlebat
2014-01-03 18:14 ` Oliver Neukum
2014-01-03 19:34 ` art1
2014-01-06 12:34 ` Denis Turischev
2014-01-07 10:03 ` Takashi Iwai
2014-01-07 23:11 ` Sarah Sharp
2014-01-08 12:57 ` Denis Turischev
2014-02-04 11:10 ` [PATCH] " Denis Turischev
2014-02-18 7:42 ` [RESEND] " Denis Turischev
2014-02-18 18:54 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219163821.GA27409@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=denis.turischev@compulab.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.