From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vtgg7-0007Vt-Ln for kexec@lists.infradead.org; Thu, 19 Dec 2013 16:42:28 +0000 Date: Thu, 19 Dec 2013 16:41:44 +0000 From: Matt Fleming Subject: Re: [PATCH v6 10/14] efi: only print saved efi runtime maps instead of all memmap ranges for kexec Message-ID: <20131219164144.GG3145@console-pimps.org> References: <1387186235-15972-1-git-send-email-dyoung@redhat.com> <1387186235-15972-11-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1387186235-15972-11-git-send-email-dyoung@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: mjg59@srcf.ucam.org, msalter@redhat.com, linux-efi@vger.kernel.org, toshi.kani@hp.com, greg@kroah.com, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, leif.lindholm@linaro.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, akpm@linux-foundation.org, mingo@kernel.org, vgoyal@redhat.com On Mon, 16 Dec, at 05:30:31PM, Dave Young wrote: > For kexec/kdump kernel efi runtime mappings are saved, printing original whole > memmap ranges does not make sense anymore. So introduce a new function to only > print runtime maps in case kexec/kdump kernel is used. > > changelog: > Matt: use efi_setup instead of esdata > share function print_efi_memmap for both normal and kexec boot. > > Signed-off-by: Dave Young > --- > arch/x86/platform/efi/efi.c | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) Thinking about this a bit more, I'm not at all sure why this patch exists. Why do we not want to print the entire memory map range like we did in the first kernel? The e820 map is printed exactly like it was in the first kernel, why should the EFI memmap be special? -- Matt Fleming, Intel Open Source Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH v6 10/14] efi: only print saved efi runtime maps instead of all memmap ranges for kexec Date: Thu, 19 Dec 2013 16:41:44 +0000 Message-ID: <20131219164144.GG3145@console-pimps.org> References: <1387186235-15972-1-git-send-email-dyoung@redhat.com> <1387186235-15972-11-git-send-email-dyoung@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1387186235-15972-11-git-send-email-dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Young Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, toshi.kani-VXdhtT5mjnY@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: linux-efi@vger.kernel.org On Mon, 16 Dec, at 05:30:31PM, Dave Young wrote: > For kexec/kdump kernel efi runtime mappings are saved, printing original whole > memmap ranges does not make sense anymore. So introduce a new function to only > print runtime maps in case kexec/kdump kernel is used. > > changelog: > Matt: use efi_setup instead of esdata > share function print_efi_memmap for both normal and kexec boot. > > Signed-off-by: Dave Young > --- > arch/x86/platform/efi/efi.c | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) Thinking about this a bit more, I'm not at all sure why this patch exists. Why do we not want to print the entire memory map range like we did in the first kernel? The e820 map is printed exactly like it was in the first kernel, why should the EFI memmap be special? -- Matt Fleming, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755803Ab3LSQmI (ORCPT ); Thu, 19 Dec 2013 11:42:08 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:60219 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755669Ab3LSQmG (ORCPT ); Thu, 19 Dec 2013 11:42:06 -0500 Date: Thu, 19 Dec 2013 16:41:44 +0000 From: Matt Fleming To: Dave Young Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de, greg@kroah.com, toshi.kani@hp.com, akpm@linux-foundation.org, mingo@kernel.org, msalter@redhat.com, leif.lindholm@linaro.org Subject: Re: [PATCH v6 10/14] efi: only print saved efi runtime maps instead of all memmap ranges for kexec Message-ID: <20131219164144.GG3145@console-pimps.org> References: <1387186235-15972-1-git-send-email-dyoung@redhat.com> <1387186235-15972-11-git-send-email-dyoung@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387186235-15972-11-git-send-email-dyoung@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Dec, at 05:30:31PM, Dave Young wrote: > For kexec/kdump kernel efi runtime mappings are saved, printing original whole > memmap ranges does not make sense anymore. So introduce a new function to only > print runtime maps in case kexec/kdump kernel is used. > > changelog: > Matt: use efi_setup instead of esdata > share function print_efi_memmap for both normal and kexec boot. > > Signed-off-by: Dave Young > --- > arch/x86/platform/efi/efi.c | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) Thinking about this a bit more, I'm not at all sure why this patch exists. Why do we not want to print the entire memory map range like we did in the first kernel? The e820 map is printed exactly like it was in the first kernel, why should the EFI memmap be special? -- Matt Fleming, Intel Open Source Technology Center