From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46578)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1VtkPs-0002ox-Po
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 15:42:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1VtkPd-0004dj-Qi
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 15:41:56 -0500
Received: from e32.co.us.ibm.com ([32.97.110.150]:55916)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1VtkPd-0004dW-K9
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 15:41:41 -0500
Received: from /spool/local
	by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Thu, 19 Dec 2013 13:41:40 -0700
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <1387385291-7825-1-git-send-email-coreyb@linux.vnet.ibm.com>
References: <1387385291-7825-1-git-send-email-coreyb@linux.vnet.ibm.com>
Message-ID: <20131219204134.11040.35628@loki>
Date: Thu, 19 Dec 2013 14:41:34 -0600
Subject: Re: [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: pmoore@redhat.com, qemu-stable@nongnu.org, aliguori@amazon.com, otubo@linux.vnet.ibm.com

Quoting Corey Bryant (2013-12-18 10:48:11)
> This fixes a bug where we weren't exiting if seccomp_init() failed.
> =

> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>

Cc'ing qemu-stable

> ---
>  qemu-seccomp.c | 1 +
>  1 file changed, 1 insertion(+)
> =

> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index cf07869..b7c1253 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -231,6 +231,7 @@ int seccomp_start(void)
> =

>      ctx =3D seccomp_init(SCMP_ACT_KILL);
>      if (ctx =3D=3D NULL) {
> +        rc =3D -1;
>          goto seccomp_return;
>      }
> =

> -- =

> 1.8.1.4