From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: netfilter-devel@vger.kernel.org,
Hannes Frederic Sowa <hannes@stressinduktion.org>
Subject: Re: [PATCH net] net: nft: call ipv6_find_hdr() with explicitly initialized offset
Date: Fri, 20 Dec 2013 11:26:30 +0100 [thread overview]
Message-ID: <20131220102630.GA16971@localhost> (raw)
In-Reply-To: <1387534995-28883-1-git-send-email-dborkman@redhat.com>
On Fri, Dec 20, 2013 at 11:23:15AM +0100, Daniel Borkmann wrote:
> In nft's nft_exthdr_eval() routine we process IPv6 extension header
> through invoking ipv6_find_hdr(), but we call it with an uninitialized
> offset variable that contains some stack value. In ipv6_find_hdr()
> we then test if the value of offset != 0 and call skb_header_pointer()
> on that offset in order to map struct ipv6hdr into it. Fix it up by
> initializing offset to 0 as it was probably intended to be.
good catch, applied. Thanks Daniel.
prev parent reply other threads:[~2013-12-20 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 10:23 [PATCH net] net: nft: call ipv6_find_hdr() with explicitly initialized offset Daniel Borkmann
2013-12-20 10:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220102630.GA16971@localhost \
--to=pablo@netfilter.org \
--cc=dborkman@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.